Ticket #7402 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

AlignAndFocusPowder used now-removed property name in EditInstrumentGeometry

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: critical Milestone: Release 2.6
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The property NewInstrument was removed from EditInstrumentGeometry in #7362. This ticket was erroneously tested (by me) before the system tests had run on and it broke SNSPowderRedux.SeriesAndConjoinFilesTest.

Change History

comment:1 Changed 7 years ago by Russell Taylor

Re #7402. Remove references to removed property name.

Changeset: 29aa42a023112ba7c88dc272e443c72096a9073d

comment:2 Changed 7 years ago by Russell Taylor

  • Status changed from new to accepted

comment:3 Changed 7 years ago by Russell Taylor

Merge branch 'bugfix/7402_using_removed_property' into develop Re #7402

Conflicts:

Code/Mantid/Framework/TestHelpers/inc/MantidTestHelpers/WorkspaceCreationHelper.h Code/Mantid/MantidQt/API/inc/MantidQtAPI/ScriptRepositoryView.ui

Changeset: ae1242b7ac3557a70ccf02948ff5332062e710ef

comment:4 Changed 7 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:6 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

All unit tests are OK. The problem system test is OK as well. The removed lines would have pointed to the default parameter anyway

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8248

Note: See TracTickets for help on using tickets.