Ticket #7428 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Bring pyChoper code written by Arianna and Jon into Mantid

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 2.6
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: #7554 Tester: Nick Draper

Description (last modified by Nick Draper) (diff)

There is piece of code, written by visiting stuedent and our scientist and widely used on inelastic instruments, which calculates the chopper instrument resolution.

The code can benefit from improvements and merges but the first step would be to bring this code within Manitd.

Change History

comment:1 Changed 7 years ago by Alex Buts

refs #7428 Added PyChop and LET chop code

Changeset: aff3c83009738484122f2eb044e5006b58b6b586

comment:2 Changed 7 years ago by Alex Buts

refs #7428 Changes to make the code a bit more usable

but just a bit

Changeset: 5e5b685face6c283462dcddca4a16daa111500f3

comment:3 Changed 7 years ago by Alex Buts

refs #7428 the head of all this.

Changeset: dc568c8878e6a5aaadf557f4996daefe76313a78

comment:4 Changed 7 years ago by Alex Buts

  • Status changed from new to accepted

I am almost sorry for taking this ticket as the code (especially pychop) needs a lot of improvements.

I tried to do what I can but it is the limit on what I can do in half a day.

To Tester. The purpose of the ticket is achieved. You should add PyChop to mantid.properties mantidqt.python_interfaces and check if it works (if everything has been added to Mantid)

If one has default instrument LET, the code behaves differently (and calls different GUI) then if the instrument is anything else.

The code itself needs substantial work and improvements + GUI has to be made one, but this can be achieved within another tickets.

comment:5 Changed 7 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Description modified (diff)
  • Tester set to Nick Draper

comment:7 Changed 7 years ago by Nick Draper

  • Blocking 6891, 7554 added

This is just adding some python scripts, they are not added to the interfaces by this commit.

Passed, but follow on tickets created:

  • #6891 Merge functionality with 'Garrets scripts' & add as interface
  • #7554 Improve code quality & write unit tests

comment:8 Changed 7 years ago by Nick Draper

  • Blocking 6891 removed

comment:9 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7428_ChopInMantid'

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8274

Note: See TracTickets for help on using tickets.