Ticket #7554 (closed: wontfix)
Improve code quality of pyChop and add unit tests
Reported by: | Nick Draper | Owned by: | Stuart Campbell |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.0 |
Component: | Direct Inelastic | Keywords: | |
Cc: | campbellsi@… | Blocked By: | #7428 |
Blocking: | Tester: | Andrei Savici |
Description
Follow on from #7428.
The adopted code needs improvement and unit tests defined.
Change History
comment:3 Changed 7 years ago by Alex Buts
- Keywords Poker added
fixing the existing code is not difficult. An simple interface for calculating resolution should be written. Then couple of specific classes would inherit from it and use existing code either to read data from file on disk or use current code which is wrong but can be deployed for the time being.
Doing all this should be no longer then a week (taking in consideration my reading on good practice for implementing python interfaces/inheritance and writing unit tests)
But there is Gurrets scripts which I know nothing about. In addition, it may requesting implementing chopper parameters database somewhere)
These are two unknowns which make this ticket unpredictable for me.
comment:4 Changed 7 years ago by Stuart Campbell
- Owner changed from Alex Buts to Stuart Campbell
- Status changed from new to verify
- Resolution set to wontfix