Improving MUON settings usage Time axis

[Gesner Passos]

When you change the combobox TimeAxis to CustomValue, you them edit the values start and finish. If you press ENTER the plot is refreshed. But, pressing TAB is more naturally.

I guess there is a connection SIGNAL/SLOT to pressing ENTER, may be, connecting to finishing edition could make it more naturally.

[Arturs Bekasovs]

The whole signal system is a bit messed up currently (for settings tab at least), so while doing this ticket I will make it more consistent and natural.

[Arturs Bekasovs]

Restructure connects so they are grouped by elements.

Helps to find redundant and replicated ones.

Refs #7555

Changeset: aac6e76f2fbf77e84422101bbd0f5521ba54743b

[Arturs Bekasovs]

Make slot names consistent.

Refs #7555

Changeset: f4e2dc32a7e03900c0114e16589629edb42883c8

[Arturs Bekasovs]

Make all the updated take place when editing is finished.

Some of them were happening when focus is lost, others when enter is pressed, now it all happens when the value was changed.

Refs #7555

Changeset: bc7ff8c32eb6c43f46a9463f10e44da4f661ac75

[Arturs Bekasovs]

Removed unnecessary slot.

Refs #7555

Changeset: 124908c83caa76be0cc0a51d3262b7f4a591ecf3

[Arturs Bekasovs]

The change requested was implemented, though it doesn't look to be useful with the current state of affairs. Redrawing the plot every time the QLineEdit loses focus seems to be rather inconvenient, e.g. in the following situation:

1. We plot something from Muon interface.
2. We change the value for start time, and press tab. Instead of moving focus to the next input widgets, the newly created plot window gets the focus, which isn't what user expects.
3. Close the plot window, focus returns to start time input. Now wherever we click next, the plot window will get redrawn, as input loses focus again. That's rather annoying.

So the solution might be to really "update" the plot instead of closing it and drawing again (which would help to fix #5116 as well), but it would not work when "Redraw" option is disabled, as then we are creating a new graph for every update.

Need to talk to Anders when he returns to decide on the solution.

[Arturs Bekasovs]

After talking to Anders, it was decided to stop working on it for now as it actually is better as it was. Possibly, some of the future changes will allow to finish this one, so putting in Backlog for now.

[Nick Draper]

moved to Release 3.0 as these all seem to be active

[Arturs Bekasovs]

Was active and indeed implemented, but turned out to be not too useful, so is definitely not for realease. Will speak to Anders about closing it as invalid.

[Peter Peterson]

Should have moved things from backlog into the release before working on it.

[Arturs Bekasovs]

Was moved to back-log on purpose when completed. Need to decided what to do with such kind of tickets. Moving back to back-log for now.

[Arturs Bekasovs]

All of the text inputs in the Muon Analysis interface are causing plot auto-update only if Enter is pressed. There are two reasons for that:

• Doing any UI actions on focus-out events is very inconvenient. If you e.g. switch windows while editing, the event will still be emitted and if it causes a new window to be plotted, the new window will get the focus instead of the one you were switching to. Other sorts of problems happen as well.

• With editingFinished signals there is not way for users to "cancel" plot auto-update. So if they enter on the text field and then decide they don't actually need to update the value, they can't finish editing without causing the current plot to auto-update. With combo-boxes you can always click outside the combo-box to avoid value change.

This approach seems to work and scientists are not complaining, so I wouldn't want to make this particular field to behave differently.

[Russell Taylor]

The branch from this ticket is still up on github - any objection to my deleting it?

[Arturs Bekasovs]

Nope, none at all. Forgot to do it myself.

[Stuart Campbell]

This ticket has been transferred to github issue ​8400