Ticket #7555 (closed: wontfix)

Opened 7 years ago

Last modified 5 years ago

Improving MUON settings usage Time axis

Reported by: Gesner Passos Owned by: Arturs Bekasovs
Priority: trivial Milestone: Release 3.1
Component: Muon Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

When you change the combobox TimeAxis to CustomValue, you them edit the values start and finish. If you press ENTER the plot is refreshed. But, pressing TAB is more naturally.

I guess there is a connection SIGNAL/SLOT to pressing ENTER, may be, connecting to finishing edition could make it more naturally.

Change History

comment:1 Changed 7 years ago by Arturs Bekasovs

  • Owner changed from Anders Markvardsen to Arturs Bekasovs

comment:2 Changed 7 years ago by Arturs Bekasovs

  • Milestone changed from Backlog to Release 3.0

comment:3 Changed 7 years ago by Arturs Bekasovs

The whole signal system is a bit messed up currently (for settings tab at least), so while doing this ticket I will make it more consistent and natural.

comment:4 Changed 7 years ago by Arturs Bekasovs

  • Status changed from new to inprogress

Restructure connects so they are grouped by elements.

Helps to find redundant and replicated ones.

Refs #7555

Changeset: aac6e76f2fbf77e84422101bbd0f5521ba54743b

comment:5 Changed 7 years ago by Arturs Bekasovs

Make slot names consistent.

Refs #7555

Changeset: f4e2dc32a7e03900c0114e16589629edb42883c8

comment:6 Changed 7 years ago by Arturs Bekasovs

Make all the updated take place when editing is finished.

Some of them were happening when focus is lost, others when enter is pressed, now it all happens when the value was changed.

Refs #7555

Changeset: bc7ff8c32eb6c43f46a9463f10e44da4f661ac75

comment:7 Changed 7 years ago by Arturs Bekasovs

Removed unnecessary slot.

Refs #7555

Changeset: 124908c83caa76be0cc0a51d3262b7f4a591ecf3

comment:8 Changed 7 years ago by Arturs Bekasovs

The change requested was implemented, though it doesn't look to be useful with the current state of affairs. Redrawing the plot every time the QLineEdit loses focus seems to be rather inconvenient, e.g. in the following situation:

  1. We plot something from Muon interface.
  2. We change the value for start time, and press tab. Instead of moving focus to the next input widgets, the newly created plot window gets the focus, which isn't what user expects.
  3. Close the plot window, focus returns to start time input. Now wherever we click next, the plot window will get redrawn, as input loses focus again. That's rather annoying.

So the solution might be to really "update" the plot instead of closing it and drawing again (which would help to fix #5116 as well), but it would not work when "Redraw" option is disabled, as then we are creating a new graph for every update.

Need to talk to Anders when he returns to decide on the solution.

Last edited 7 years ago by Arturs Bekasovs (previous) (diff)

comment:9 Changed 7 years ago by Arturs Bekasovs

  • Milestone changed from Release 3.0 to Backlog

After talking to Anders, it was decided to stop working on it for now as it actually is better as it was. Possibly, some of the future changes will allow to finish this one, so putting in Backlog for now.

comment:10 Changed 7 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.0

moved to Release 3.0 as these all seem to be active

comment:11 Changed 7 years ago by Arturs Bekasovs

  • Milestone changed from Release 3.0 to Backlog

Was active and indeed implemented, but turned out to be not too useful, so is definitely not for realease. Will speak to Anders about closing it as invalid.

comment:12 Changed 7 years ago by Peter Peterson

  • Milestone changed from Backlog to Release 3.0

Should have moved things from backlog into the release before working on it.

comment:13 Changed 7 years ago by Arturs Bekasovs

  • Milestone changed from Release 3.0 to Backlog

Was moved to back-log on purpose when completed. Need to decided what to do with such kind of tickets. Moving back to back-log for now.

comment:14 Changed 7 years ago by Arturs Bekasovs

  • Keywords Student removed
  • Status changed from inprogress to verify
  • Resolution set to wontfix

All of the text inputs in the Muon Analysis interface are causing plot auto-update only if Enter is pressed. There are two reasons for that:

  • Doing any UI actions on focus-out events is very inconvenient. If you e.g. switch windows while editing, the event will still be emitted and if it causes a new window to be plotted, the new window will get the focus instead of the one you were switching to. Other sorts of problems happen as well.
  • With editingFinished signals there is not way for users to "cancel" plot auto-update. So if they enter on the text field and then decide they don't actually need to update the value, they can't finish editing without causing the current plot to auto-update. With combo-boxes you can always click outside the combo-box to avoid value change.

This approach seems to work and scientists are not complaining, so I wouldn't want to make this particular field to behave differently.

comment:15 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:16 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed
  • Milestone changed from Backlog to Release 3.1

comment:17 Changed 7 years ago by Russell Taylor

The branch from this ticket is still up on github - any objection to my deleting it?

comment:18 Changed 7 years ago by Arturs Bekasovs

Nope, none at all. Forgot to do it myself.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8400

Note: See TracTickets for help on using tickets.