Ticket #7429 (closed: fixed)
Allow SplatterPlot to handle 4D data
| Reported by: | Michael Reuter | Owned by: | Michael Reuter |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | GUI | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Owen Arnold |
Description
Currently, the SplatterPlot view is tailored for 3D data and does not handle 4D data well. In principle, this shouldn't be an issue, so we'll need to figure out how.
Change History
comment:3 Changed 7 years ago by Michael Reuter
- Status changed from new to inprogress
- Milestone changed from Backlog to Release 3.0
comment:4 Changed 7 years ago by Michael Reuter
Refs #7429. First cut at turning 4D back on.
Changeset: 2776c4e1529dc88e227360bc46781447ee7f426d
comment:5 Changed 7 years ago by Michael Reuter
Refs #7429. Don't put timestep stuff in XML as this causes issues.
Changeset: 3e9314ea5174aa188f5a3d98577d78f0c2578b1e
comment:6 Changed 7 years ago by Michael Reuter
Refs #7429. Removing debugging.
Changeset: e8bff2821c995142e7e5b69629ff7df6f8bf265d
comment:7 Changed 7 years ago by Michael Reuter
Refs #7429. Lifting restrictions on 4D data.
Changeset: 5228963db23a3b3aebe846ac386fb55c776a762c
comment:8 Changed 7 years ago by Michael Reuter
Refs #7429. Fixing unit test for 4D data.
Changeset: e70d00a3cc8d77e0fdecb59fd893841ba18ee3ff
comment:9 Changed 7 years ago by Michael Reuter
Refs #7429. Take out checks while I track down issues.
Changeset: 728b07e38bd93bf7e9850aeb6314cd3f0c8323f9
comment:10 Changed 7 years ago by Michael Reuter
Refs #7429. After further review, permanently removing bounds checks.
Due to the restriction of weak ordering on the sorted boxes and that all the boxes save the same signal strength, the sorting order of the boxes is arbitrary. Therefore, the associated events (one per box) can be at any location, so bounds checking the final VTK dataset is impossible.
Changeset: c62ac54a957f547226ed3698e26a0b0090485078
comment:11 Changed 7 years ago by Michael Reuter
- Status changed from inprogress to verify
- Resolution set to fixed
The branch is here.
To test: Load SEQ_MDEW.nxs into MantidPlot, open in the VSI and switch to the SplatterPlot mode. Due to the low event count, you won't see any data, so move the Top Percentile slider to show 100%. Then use the animation controls to see the fun. Be sure to flip back to the Standard mode to ensure the first view is recovered. You should also test a 3D file (like TOPAZ_3680_5_sec_MDEW.nxs) to ensure that this still works in the SplatterPlot mode properly.
comment:12 Changed 7 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:13 Changed 7 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7429_splatterplot_4D_data'
Full changeset: 2c6f14e5325f1b0e2e558d5cd15f33aecc93b69b
comment:14 Changed 7 years ago by Owen Arnold
Works as advertised. Two minor suggestions moving forward. Definitely these warrant new tickets.
1) Switching back to the standard view after running through the scatter plot should probably also reset the 'time' increment to whatever it was before the first switch to the scatterplot view.
2) It would be good if it were possible to rebin the data and then run these options on the rebinned data. Understandably for the scatter plot this option would only make sense if the user had un-checked the 'Output Histo Workspace' option on the Rebin. However, currently doing this still results the scatter plot option being disabled.
comment:15 Changed 7 years ago by Michael Reuter
My responses:
- If one uses the SplatterPlot filter in ParaView, adjusts the timestep and then deletes it to return to the original view, the timestep remains the same. So, the VSI behavior is commensurate with ParaView. So, I'm not sure about this one.
- Good point. See #8115.
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8275
