Ticket #7442 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Use MWRunFiles in DGS Reduction GUI for the setting of the sample data file

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 2.6
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Andrei Savici) (diff)

Swap in the MWRunFiles widget (exposed to python in #7433) in place of the sample_label/edit/browse widgets in dgs_sample_setup.py.

This is a precursor to incorporating a live button into the MWRunFiles widget itself and using that here (see #5896).

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Russell Taylor

Re #7442. Use MWRunFiles widget in DGS reduction GUI.

It has to be swapped in at runtime because: (a) pyuic doesn't know anything about MWRunFiles, & (b) there's a desire to have these GUIs runnable even from outside MantidPlot

Changeset: 3141cb0ae95305e0c104d6c732c807ae82efdb55

comment:3 Changed 7 years ago by Russell Taylor

Re #7442. Add ability to set minimum width on the label.

Also expose this new method via python.

Changeset: 768ba6321c5d5d51c8ad6ed4eaacbefc817f4059

comment:4 Changed 7 years ago by Russell Taylor

Re #7442. Apply minimum width to label in MWRunFiles widget.

This restores the alignment of the text edit boxes.

Changeset: 3ecbaf30ec0b816502b37a2a662020712c85bd37

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: Branch is feature/7442_mwrunfiles_in_dgs_reduction_gui

The top line of the first tab in the DGS Reduction GUI (created from the Interfaces menu item) is now the MWRunFiles widget if the GUI is run from within MantidPlot. This is the line labelled 'Sample Data'. The only observable differences should be the apparition of the validity asterisk with it's tooltip text and the hooking up of file validity to whether the QLineEdit's background is yellow or not (previously it only changed if the box was empty).

Check that file browsing, selection, typing all works correctly and that you can reduce a valid file successfully. Test the use of the 'Incident Energy Guess' lineedit as this shares some methods with the sample one.

comment:6 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Description modified (diff)
  • Tester set to Andrei Savici

comment:7 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7442_mwrunfiles_in_dgs_reduction_gui'

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8288

Note: See TracTickets for help on using tickets.