Ticket #7459 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

FilterEvents has wrong log values

Reported by: Andrei Savici Owned by: Wenduo Zhou
Priority: critical Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Andrei Savici) (diff)

I tried to run the following script

Load(Filename=r'/SNS/ARCS/2012_2_18_CAL/data/ARCS_30489_event.nxs',OutputWorkspace='ARCS_30489_event',LoadMonitors='1')
GenerateEventsFilter(InputWorkspace='ARCS_30489_event',OutputWorkspace='f',InformationWorkspace='fi',UnitOfTime='Nanoseconds',LogName='CCR12Rot',MinimumLogValue='-50',MaximumLogValue='-20',LogValueInterval='1',FilterLogValueByChangingDirection='Decrease')
FilterEvents(InputWorkspace='ARCS_30489_event',OutputWorkspaceBaseName='filtered',InformationWorkspace='fi',SplitterWorkspace='f',FilterByPulseTime='1',GroupWorkspaces='1')
  1. I expect that in workspace 1 to have events from CCR12Rot=-49 to -48. I get events from -49.5 to -48.5. The documentation needs to be changed. Or the algorithm should do as expected
  2. The more problematic is the first (sometimes the last - depending on direction) workspace. In workspace 0 I expect to see data from -50.5 to -49.5 (in the current way of handling this), but the lower limit is -65.2. I am not sure if the events are filtered correctly, but I am sure that the log values are not

Change History

comment:1 Changed 7 years ago by Andrei Savici

  • Description modified (diff)

comment:2 Changed 7 years ago by Andrei Savici

  • Description modified (diff)

comment:3 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:4 Changed 7 years ago by Wenduo Zhou

Cleaned codes and add some more debug output. Refs #7459.

Changeset: 14933e2d7921f904b9df217a9f557a106da81d64

comment:5 Changed 7 years ago by Wenduo Zhou

Fixed bug and add debug log. Refs #7459.

Changeset: 5431ada6d60739d34fd629c5f2a647a73a275590

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:7 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:8 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to inprogress

comment:9 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

Documentation of GenerateEventsFilter is improved on how to specify the log value interval (http://www.mantidproject.org/GenerateEventsFilter)

comment:10 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:11 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/7459_filter_log'

comment:12 Changed 7 years ago by Andrei Savici

It could still use some improvement in documentation

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8304

Note: See TracTickets for help on using tickets.