Ticket #7461 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Rename HDFDescriptor to NexusDescriptor

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Mathieu Doucet

Description

It wraps a nexus file so be more explicit about it. We also may want to implement a specific HDF5Descriptor to use the HDF

Also have the IFileLoader class be templated on the descriptor type to avoid having to reimplement it for each new type.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:6 Changed 7 years ago by Martyn Gigg

  • Status changed from new to inprogress

Use more specific Nexus name instead of HDF in file loaders

  • Rename HDFDescriptor to NexusDescriptor
  • Rename {HDF,NonHDF} -> {Nexus,Generic} in FileLoaderRegistry
  • Rename DECLARE_HDF_FILELOADER_ALGORITHM -> DECLARE_NEXUS_FILELOADER_ALGORITHM

Refs #7461

Changeset: 5b7039daf7e3284bc1ed52193a8d2eee4666e461

comment:7 Changed 7 years ago by Martyn Gigg

Make the IFileLoader interface a template. Refs #7461

This avoids having to declare a new interface when a new loader type is added.

Changeset: 5e468d1c7a75222f835fa8e94e2586328eb6892f

comment:8 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: feature/7461_rename_hdfdescriptor_to_nexusdescriptor

Tester: There should be no user-facing changes at all. This was purely a tidy-up from #7263 to make it more explicit that the HDF descriptor was actually a NexusDescriptor.

All of the tests & system tests should still work and it would be a good idea to check the loading from MantidPlot->Load with a few different file types (NeXus and Non-NeXus) to see that the correct loader is picked.

comment:9 Changed 7 years ago by Mathieu Doucet

  • Status changed from verify to verifying
  • Tester set to Mathieu Doucet

comment:10 Changed 7 years ago by Mathieu Doucet

  • Status changed from verifying to closed

Everything seems to work normally.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8306

Note: See TracTickets for help on using tickets.