Ticket #7462 (closed: fixed)
Extend the MWRunFiles widget to incorporate a 'live data' button
Reported by: | Russell Taylor | Owned by: | Russell Taylor |
---|---|---|---|
Priority: | critical | Milestone: | Release 2.6 |
Component: | GUI | Keywords: | LiveData |
Cc: | Blocked By: | ||
Blocking: | Tester: | Andrei Savici |
Description (last modified by Russell Taylor) (diff)
This will be similar to what is currently done in the Step Scan GUI with separate widgets.
Once the title part is done, incorporate it into the Step Scan Custom Interface.
Change History
comment:3 Changed 7 years ago by Russell Taylor
Re #7462. Add a live button to the MWRunFiles widget.
By default the button is hidden and disabled, so existing uses of this widget will be entirely unaffected.
A property has been added so that the button can be set to be always hidden and disabled, only shown if able to connect to the default instrument or always shown (but only enabled if able to connect). Selecting the live button will disable the file text box/browse button & vice versa.
Changeset: c841f6359183a1b8deb6eff1d959881dd5191f77
comment:4 Changed 7 years ago by Russell Taylor
Re #7462. Use MWRunFiles live button in Step Scan GUI.
Replacing the previous separate QToolButton widget.
Changeset: 49a2dbe6833406e9b0f6e2e444544ea4e4b4e05d
comment:7 Changed 7 years ago by Russell Taylor
Re #7462. Move a slot from public to private.
Changeset: 9c8e6048f0a236c1244d93437045511a5087ff0b
comment:8 Changed 7 years ago by Russell Taylor
Re #7462. Move handling of stopping live algorithm up to MWRunFiles.
Moved up from CustomInterfaces::StepScan for reuse.
Changeset: 089af43e5a20a5942157e088f455ea69c652bdc7
comment:10 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Tester: Branch is feature/7462_mwrunfiles_gains_live_button
The main thing to check is that this hasn't broken other places that use the MWRunFiles widget (e.g. the Load dialog), so pick a couple to look at. The new button is hidden and inactive by default so should have no effect.
The one place right now that is using it is the Step Scan GUI (accessed from the Interfaces menu), so check the behaviour there as far as you can. Check it on the offline side by using the HYSA_2934.nxs.h5 in the systemtests repo. On the live side, you're probably limited to doing it by inspection unless you're running somewhere that can access the HYSPEC or SEQUOIA live streams.
comment:11 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:12 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
On the ISIS side hitting the live data button in the Step Scan gui gives the Unexpected error. I am not sure whether it is coming form MWRunFiles widget or from the interface, reopening just in case.
comment:13 Changed 7 years ago by Russell Taylor
Re #7462. Remove irrelevant const's in declarations.
Having const on a value parameter in the declaration is meaningless. It can still be used in the definition where it does have an effect.
Changeset: 4cba5d338fbba49b78f0689e01de22403e3e709f
comment:14 Changed 7 years ago by Russell Taylor
Re #7462. Add protection against trying to use with invalid stream.
The Step Scan Interface can only be used with event streams. It now gives an error message if trying to use it with a histogram listener, or if StartLiveData fails for any other reason. Previously, there would be an uncaught exception thrown.
Changeset: 56bf1a10029546f42f17b34c56efa2161f10bdab
comment:15 Changed 7 years ago by Russell Taylor
Gave wrong ticket number in commit...
Re #7482. Add setters to toggle state of live button.
Can now be enabled/disabled & checked/unchecked from the outside.
Changeset: c6861053461506f3f71f3dc933f98eaac502225e
comment:16 Changed 7 years ago by Russell Taylor
- Status changed from reopened to verify
- Resolution set to fixed
The ISIS error was nothing new, but nonetheless I've fixed it here.
comment:17 Changed 7 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester changed from Roman Tolchenov to Andrei Savici
comment:18 Changed 7 years ago by Andrei Savici
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7462_mwrunfiles_gains_live_button'
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8307