Ticket #7463 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Remove calls to RunOldPythonScript from EQSANS code

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: critical Milestone: Release 2.6
Component: Python Keywords:
Cc: Blocked By:
Blocking: #7483 Tester: Russell Taylor

Description (last modified by Mathieu Doucet) (diff)

The EQSANS code still calls RunOldPythonScript algorithm.

The part of the code that calls RunOldPythonScript is obsolete code that was used for prototyping the live reduction. Simply remove EQSANSReduce and remove the SetupReducer property of SetupEQSANSReduction.

Change History

comment:1 Changed 7 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Mathieu Doucet

Re #7463 Remove old and unused code

Changeset: 05da8a28ff18e0fbc060f8042c4d1ab649bcd534

comment:3 Changed 7 years ago by Mathieu Doucet

  • Description modified (diff)

comment:4 Changed 7 years ago by Mathieu Doucet

To Test:

  • Make sure all EQSANS system tests run.
  • Play around with the reduction UI and make sure it runs.
  • Check that there is no use of RunOldPythonScript in the reduction code.

comment:5 Changed 7 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:7 Changed 7 years ago by Russell Taylor

  • Blocking 7483 added

comment:7 Changed 7 years ago by Russell Taylor

  • Blocking 7483 removed

No more mention of RunOldPythonScript, all tests passing.

Nothing else was using RunOldPythonScript, so it will be removed under #7483.

comment:8 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

comment:9 Changed 7 years ago by Russell Taylor

  • Blocking 7483 added

comment:10 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Python API

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8308

Note: See TracTickets for help on using tickets.