Set graph/matrix/table close confirmations off by default for new and existing users

[Owen Arnold]

The current implementation of the reflectometry GUI delivered by Max involves the user intervention owing to changes to plotted workspaces. This should not be necessary.

To invoke this issue, repeat the tests provided against ticket #7372.

The change here is to turn off all confirmations for the end user, once for each user on each machine (per Qsettings instance). Only do this once so if a user then purposefully turns a confirmation back on it will be left alone.

[Nick Draper]

re #7466 Added once only default change code

Changeset: d1bdcfc34a7cf69e9edd7688d14f98c65813ae86

[Nick Draper]

To Test:

1. Start Mantidplot
2. File->new->table
3. Click the X on the table to close it.
4. No Confirmation dialog should appear
5. Open View->preferences General->Confirmations
6. Only the "Prompt on renaming ..." should be selected
7. Select Tables -> OK
   1. repeat 2 to 3, you should get a confirmation box this time
   2. reset the preference to off
   3. repeat for somethings other than tables
8. in the preferences set a few confirmations to true
9. close mantidplot and reopen
10. check you prefereces were persisted
11. reset all of the values to false.
12. run the test in #7372, no irritating dialogs should appear.

[Mathieu Doucet]

I see that the code should be doing the right thing but the scenario above fails at step 4.

[Nick Draper]

Retest on Mac please

[Owen Arnold]

Doesn't seem to work on the Mac. I'll find out why.

[Owen Arnold]

We've tested this quite thoroughly on the Mac, and see no problems. Although we can't explain why it failed when I built from source, the changes should not cause any harm. It's now doing exactly what it's supposed to according to the commit changes.

[Owen Arnold]

Merge remote-tracking branch 'origin/feature/7466_Change_confirmation_defaults'

[Stuart Campbell]

This ticket has been transferred to github issue ​8311