Ticket #7466 (closed: fixed)
Set graph/matrix/table close confirmations off by default for new and existing users
Reported by: | Owen Arnold | Owned by: | Nick Draper |
---|---|---|---|
Priority: | blocker | Milestone: | Release 2.6 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | #7372 | |
Blocking: | Tester: | Owen Arnold |
Description (last modified by Nick Draper) (diff)
The current implementation of the reflectometry GUI delivered by Max involves the user intervention owing to changes to plotted workspaces. This should not be necessary.
To invoke this issue, repeat the tests provided against ticket #7372.
The change here is to turn off all confirmations for the end user, once for each user on each machine (per Qsettings instance). Only do this once so if a user then purposefully turns a confirmation back on it will be left alone.
Change History
comment:4 Changed 7 years ago by Nick Draper
- Status changed from new to inprogress
- Owner changed from Owen Arnold to Nick Draper
comment:5 Changed 7 years ago by Nick Draper
- Description modified (diff)
- Summary changed from Reflectometry GUI stop-starts to Set graph/matrix/table cose confirmations off by default for new and existing users
comment:6 Changed 7 years ago by Nick Draper
re #7466 Added once only default change code
Changeset: d1bdcfc34a7cf69e9edd7688d14f98c65813ae86
comment:7 Changed 7 years ago by Nick Draper
- Priority changed from major to blocker
- Status changed from inprogress to verify
- Resolution set to fixed
To Test:
- Start Mantidplot
- File->new->table
- Click the X on the table to close it.
- No Confirmation dialog should appear
- Open View->preferences General->Confirmations
- Only the "Prompt on renaming ..." should be selected
- Select Tables -> OK
- repeat 2 to 3, you should get a confirmation box this time
- reset the preference to off
- repeat for somethings other than tables
- in the preferences set a few confirmations to true
- close mantidplot and reopen
- check you prefereces were persisted
- reset all of the values to false.
- run the test in #7372, no irritating dialogs should appear.
comment:8 Changed 7 years ago by Nick Draper
- Summary changed from Set graph/matrix/table cose confirmations off by default for new and existing users to Set graph/matrix/table close confirmations off by default for new and existing users
comment:9 Changed 7 years ago by Mathieu Doucet
- Status changed from verify to verifying
- Tester set to Mathieu Doucet
comment:10 Changed 7 years ago by Mathieu Doucet
- Status changed from verifying to reopened
- Resolution fixed deleted
I see that the code should be doing the right thing but the scenario above fails at step 4.
comment:11 Changed 7 years ago by Nick Draper
- Status changed from reopened to verify
- Resolution set to fixed
Retest on Mac please
comment:12 Changed 7 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester changed from Mathieu Doucet to Owen Arnold
comment:13 Changed 7 years ago by Owen Arnold
Doesn't seem to work on the Mac. I'll find out why.
comment:14 Changed 7 years ago by Owen Arnold
- Status changed from verifying to closed
We've tested this quite thoroughly on the Mac, and see no problems. Although we can't explain why it failed when I built from source, the changes should not cause any harm. It's now doing exactly what it's supposed to according to the commit changes.
comment:15 Changed 7 years ago by Owen Arnold
Merge remote-tracking branch 'origin/feature/7466_Change_confirmation_defaults'
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8311