Ticket #7487 (closed: fixed)
The TEST facility should not appear in the list of facilities when setting your instrument
| Reported by: | Russell Taylor | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 2.6 |
| Component: | GUI | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Russell Taylor |
Description
Presumably as a result of #7403, it's in the list of facilities in the MantidPlot preferences and the FirstTimeSetup dialog. It should be somehow removed so it is not visible to the user.
Change History
comment:1 Changed 7 years ago by Nick Draper
- Priority changed from major to blocker
- Owner set to Martyn Gigg
comment:3 Changed 7 years ago by Martyn Gigg
Add separate facilties file for use in unit tests.
The TEST facility has been removed from the main Facilities.xml file and into its own test one. The affected unit tests now load the test file if and restore the original at the end. The FacilityHelper file defines a simple struct to does this with an object in a scoped manner.
The test file is in the IDFs_for_UnitTesting sub-directory so it does not get included in the packages. Refs #7487
Changeset: 4c81079728be03fc1413bbde29baa37aecdfc191
comment:4 Changed 7 years ago by Martyn Gigg
- Status changed from inprogress to verify
- Resolution set to fixed
Branch: feature/7487_move_TEST_facility_from_main_facilities_file
Tester: The TEST facility is now in a separate test XML file. It should now not be in the list of facilities either in the FirstTimeSetup dialog and the preferences dialog.
All of the unit tests that use the TEST facility now load the test facilities at the start of the test and reset to the standard at the end. There is a helper for this.
comment:5 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:6 Changed 7 years ago by Russell Taylor
- Status changed from verifying to closed
The TEST facility is no longer apparent from MantidPlot, and all the unit tests that use it are passing. I did notice a failure of ISISHistoDataListenerTest on our Windows build slave when this was first pushed, but that appears to be unrelated and it's been OK since (and works for me on Windows).
