Ticket #7495 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Calibration: correct the calibration of MAPS (Easy to test)

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Karl Palmen

Description

The current example of maps calibration does a bad job for the e window. This is because the data itself can not be used to calibrate that door.

Remove the attempt to calibrate that door from the maps example.

TubeCalibDemoMaps_All

Attachments

wrong_cal_maps.png (40.3 KB) - added by Gesner Passos 7 years ago.
The previous wrong answer.

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress
  • Cc anders.markvardsen@… added

comment:2 Changed 7 years ago by Gesner Passos

Remove the E window from the calibration of MAPS

This solve the issue of trying to calibrate the E window, which produces bad result.

re #7495

Changeset: e40c7323f17503f7e2998a37a150d20e35fe3bf9

Changed 7 years ago by Gesner Passos

The previous wrong answer.

comment:3 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Summary changed from Calibration: correct the calibration of MAPS to Calibration: correct the calibration of MAPS (Easy to test)

Tester:

just the TubeCalibDemoMaps_All.py script. Them, open the instrument view, and change the rendering to cylindrical Y. Previously, the tubes from E window got larger 'touching' the other doors, as you can see in the attachment. Now, the calibration should not touch these tubes, and they should remain with the same size.

comment:4 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:5 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

E window tubes remain short rather than stretched as in attached picture.

comment:6 Changed 7 years ago by Karl Palmen

Merge remote-tracking branch 'origin/feature/7495_maps_example'

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8340

Note: See TracTickets for help on using tickets.