Ticket #7498 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

DetermineChunking little items

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: lynchve@… Blocked By:
Blocking: Tester: Vickie Lynch

Description (last modified by Peter Peterson) (diff)

  • Set maxChunk=0 to do the same as empty double in DetermineChunking. This already appears to be what is done in the code, just make it more explicit.
  • Return an empty table if there should only be one chunk for serial mode and a table with one row for mpi
  • Add support for new ADARA created files

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Peter Peterson

  • Cc lynchve@… added
  • Description modified (diff)
  • Summary changed from Set maxChunk=0 to do the same as empty double in DetermineChunking to DetermineChunking little items

comment:3 Changed 7 years ago by Peter Peterson

  • Description modified (diff)

comment:4 Changed 7 years ago by Peter Peterson

Re #7498. Return empty table for more cases.

Changeset: 20df50a5f9f870e48f96d12e23bb64dad30dce83

comment:5 Changed 7 years ago by Peter Peterson

Re #7498. Adding initial support for adara files.

Changeset: ecd19d4f1f8853ab027ab6c3fdbd77f19106e674

comment:6 Changed 7 years ago by Peter Peterson

Re #7498. Refactored code to make type selection clearer.

Changeset: 82f1c914b28e004f384a92b772265ed6ff5ddd31

comment:7 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on ​feature/7498_chunk_improvement.

Testing: Try playing with different ways of getting empty tables (serial mode):

  1. Don't specify a max chunking size
  2. Specify it as "0"
  3. Specify it as bigger than the workspace that would be created

comment:8 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:9 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

All Pete's suggested testing works. Chunking reduction still works and adara files work now.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8343

Note: See TracTickets for help on using tickets.