Ticket #7502 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Get ISIS reflectometry combineMulti under test

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 2.6
Component: Reflectometry Keywords:
Cc: Blocked By: #7317
Blocking: Tester: Gesner Passos

Description

A system test would be ideal for this. We must have confidence that quick is running properly first, because only once workspaces have been processed through quick, will they be in the correct form for stitching.

I can't start work making improvements to the user generated scripts in this area until I have some confidence that I can catch breakages.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #7502. Small modification to a really bad code block

In the process of adding tests, thus far, I have managed to almost completely avoid making any modifications to the script files going under test. I could not avoid this one however, because otherwise I'd need to have workspaces in the ADS with very specific names, only to satisfy the clean-up routine. My simple fix is just to check that the workspaces exist before trying to delete them.

Changeset: 9a887def3518fcd5afee0792407cd88614b8e91c

comment:2 Changed 7 years ago by Owen Arnold

refs #7502. New system test and standard results.

Changeset: 62e3546e8a28c36df9ca1748c8009052b1dd98e8

comment:3 Changed 7 years ago by Owen Arnold

refs #7502. Refactor test. Extract method.

Changeset: 2cce0fbdd03ebf6d5465fc47db2101ade509b48e

comment:4 Changed 7 years ago by Owen Arnold

Tester Branches on BOTH the mantid AND system test repositories will need to be merged to master both branches on both repositories are called feature/7502_test_combine_multi.

The system test should be passing on develop on all environments before merging these changes into the master branches.

comment:5 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:7 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7502_test_combine_multi'

comment:8 Changed 7 years ago by Gesner Passos

Merge remote-tracking branch 'origin/feature/7502_test_combine_multi'

comment:9 Changed 7 years ago by Gesner Passos

The system test is passing on all machines. Good code review as well.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8347

Note: See TracTickets for help on using tickets.