Ticket #7539 (closed: fixed)
ClearUB
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.0 |
| Component: | Diffraction | Keywords: | CORE |
| Cc: | Blocked By: | ||
| Blocking: | #7664 | Tester: | Peter Peterson |
Description
Create an algorithm to delete a UB off an OrientedLattice. This is a simple change, but will solve an annoying workflow problem, i.e. you want to add peaks to a peaks workspace, but the UB on that peaks workspace is not good.
Would be good to add a UI right-click option for this. If the UI option is included, don't put it in until release 3.0.
Change History
comment:3 Changed 7 years ago by Owen Arnold
- Status changed from new to inprogress
refs #7539. Method to clear the oriented lattice off a sample.
Remove the oriented lattice. Additional unit tests provided to cover this functionality.
Changeset: a31edc51f3c22f65acc9ac56ae4ad75805096f2e
comment:4 Changed 7 years ago by Owen Arnold
refs #7539. ClearUB algorithm introduced.
Algorithm exposes the clearUB capabilities on the sample. Works with both singular experiment infos and multiple experiment infos. Unit tests provided to cover implemented functionality.
Changeset: 3f17b5add4f7e54790e63be69fff2571ea7a535a
comment:5 Changed 7 years ago by Owen Arnold
- Keywords CORE added
Added CORE tag. This is because I've made changes to OrientedLattice in API. I believe these should be safe, and should be well covered by unit tests. However, OrientedLattice is a fundamental aspect of Mantid, and there must be no risk that adverse effects have been introduced.
comment:6 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
Tester: It would be best that this feature was tested by someone familiar with the single crystal workflow at the SNS. This feature is the result of a requirement from and ISIS instrument scientist.
The unit tests should give an indication of how to test this ticket. Essentially this can be done by:
- Use SetUB on an existing workspace.
- Use ClearUB on the same workspace.
- Use the hasOrientedLattice method (exposed to python) to determine that the UB/oriented lattice has been removed.
comment:8 Changed 7 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:9 Changed 7 years ago by Peter Peterson
Adding this to the UI was not done. I created #7671 to keep track of that (tiny) chunk of work.
comment:11 Changed 7 years ago by Alex Buts
refs #7539 Minor changes
Changeset: 2bc24d118719efdb5eed2470d4b4e4c649f24498
comment:12 Changed 7 years ago by Alex Buts
refs #7539 Minor changes
Changeset: 2bc24d118719efdb5eed2470d4b4e4c649f24498
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8384
Estimated Duration = 1day