Ticket #7598 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

IndirectDataAnalysis.py: Replace Height parameter with Amplitude in Lorentzian

Reported by: Martyn Gigg Owned by: Samuel Jackson
Priority: blocker Milestone: Release 2.6
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Franz spotted:

ValueError: Invalid value for property Function (Function) "name=LinearBackground,A0=0.0346633591696,A1=-0.011393532146;(composite=Convolution;name=Resolution, FileName=C:/Users/chatterji/osi101913_graphite002_res.nxs;(name=DeltaFunction,Height=3.77645724697;name=Lorentzian,Height=12.3643616699,PeakCentre=-0.00394467940272,HWHM=0.044433239019))": ParamFunction (set) parameter (Height) does not exist. Allowed parameters: Amplitude, PeakCentre, HWHM, at line 14 in '<Interface>' caused by line 204 in 'C:/MantidInstall/scripts/Inelastic\IndirectDataAnalysis.py' caused by line 115 in 'C:/MantidInstall/scripts/Inelastic\IndirectDataAnalysis.py' caused by line 185 in 'C:/MantidInstall/bin\mantid\simpleapi.py'

when running the ConvFit from the IDA interface

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Updated script to replace height with amplitude.

Also wrapped quotes around filename to stop sequential fit crashing

Refs #7598

Changeset: 7c0eec97cfb30b80e99e90be2ebf8b4e333caec7

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test:

Run a standard ConvFit and check that both Single and Sequential Fit work correctly. Instructions can be found here, substitute height with amplitude: http://www.mantidproject.org/Indirect:Indirect_Data_Analysis

comment:3 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:4 Changed 7 years ago by Martyn Gigg

Tried both single & sequential fitting with various plotting options and things look okay.

comment:5 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7598_replace_height_param'

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8443

Note: See TracTickets for help on using tickets.