GetEI v2 generates confusing message if not finds a monitor peak

[Alex Buts]

GetEI v2 currently generates some rubbish message like

"Invalid value for property Params (dbl list) "60812,-1.#IND,74325.8": Could not set property Params. Can not convert "60812,-1.#IND,74325.8" to dbl list"

if not finds a monitor peak. This confuses the instrument scientists

Nick -- it can be considered as the outcome of the testing and there is is low risk fix for that. We can include it into release 2.6.

[Alex Buts]

refs #7599 This should fix it or at least generate proper error log.

Changeset: ca96f38b2a46fc94d51dd2a8b295a0f0d310d602

[Alex Buts]

refs #7599 A bit better error message

Changeset: 8e987b2f3fc5bab9889f8d75e35303f74be232d1

[Alex Buts]

the ticket can be tested by simple script

Load(Filename=r'LET_w1reb.nxs',OutputWorkspace='LET_w1reb')
ei,time,tt=GetEi(InputWorkspace='LET_w1reb',Monitor1Spec='40966',Monitor2Spec='5506',EnergyEstimate='0.93000000000000005')

where test workspace is on ISIS FTP site:

​ftp://ftp.nd.rl.ac.uk/scratch/abuts/LET_w1reb.nxs

which will stay there until ticket is tested.

The script before fix was generating the rubbish above and after clearly says that the peak has not been found.

Tester can try other situations when the GetEi is not finding the peak it needs to identify Ei

[Jay Rainey]

Testing

• Functionality required by the ticket has been met. Outputs error message as expected.

Code review

• By logging the error then throwing the error message you are outputting two messages to the user. It's best to instead just throw the error with the log message. That is, the log message on line 242 should be inside the throw on line 243 instead.

For consistency I will reopen the ticket.

[Alex Buts]

refs #7599 Fixed inconsistency noted by tester

Changeset: 5d2d58e27c7b238d459aefaf8148c36a0e91c77d

[Jay Rainey]

Merge remote-tracking branch 'origin/bugfix/7599_ConfusingGetEI_ErrorMessage'

[Stuart Campbell]

This ticket has been transferred to github issue ​8444