Ticket #7645 (closed: fixed)
SaveAsciiTest to test WriteXError Property
| Reported by: | Karl Palmen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | #7732 | |
| Blocking: | Tester: | Alex Buts |
Description
SaveAscii test presently ignores this property completely. We need a test for this property using a workspace similar to the one generated in the test but with Xerrors.
Change History
comment:2 Changed 7 years ago by Karl Palmen
- Blocked By 7732 added
The situation may have changed as a result of work on ticket #7732. This will need checking and work done, if necessary.
comment:4 Changed 7 years ago by Keith Brown
Yes, this will have changed as I believe the new test includes tests for this too
comment:6 Changed 7 years ago by Karl Palmen
SaveAscii2Test already tests for this property. So only SaveAsciiTest needs this.
comment:7 Changed 7 years ago by Karl Palmen
I've also found that SaveAsciiTest does not test the numerical content of the file after the header other than to check that the second line with header matches the first line without header. This functionality will not be added through this ticket.
However SaveAscii2Test does test numerical content.
comment:8 Changed 7 years ago by Karl Palmen
Add test for Xerror property to SaveAsciiTest.h re #7645
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: e769a543e005a5726165ea456c35faaad34127ae
comment:9 Changed 7 years ago by Karl Palmen
To test, check that the test tests for the the correct working of the writeXerror property and for the headers produced for the first spectrum.
comment:10 Changed 7 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
comment:11 Changed 7 years ago by Karl Palmen
- Status changed from verify to reopened
- Resolution fixed deleted
Reopen to fix warning about unused specID variable.
comment:13 Changed 7 years ago by Karl Palmen
Remove unused variable re #7645
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: c1e27d90eb653d1b2c136e9b6267b690285cc276
comment:14 Changed 7 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
comment:15 Changed 7 years ago by Alex Buts
- Status changed from verify to verifying
- Tester set to Alex Buts
comment:16 Changed 7 years ago by Alex Buts
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7645_saveascii_writeXerror'
Full changeset: aa2a2d94b4f4a531101d01c06e495f8d5f177337
comment:17 Changed 7 years ago by Alex Buts
Test is there and it runs though I would check not only the header written. Another ticket may be?
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8490
