Ticket #7650 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Call getCoordinateSystem function for MDWorkspaces used in InputWorkspace

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Keith Brown

Description

One possible source of error in algorithms that input MD workspaces is if the CoordinatesToUse does not match the type of InputWorkspace. These algorithms should call a getCoordinateSystem function for MDWorkspaces instead of asking the user for this input.

Change History

comment:1 Changed 7 years ago by Vickie Lynch

  • Status changed from new to inprogress
Last edited 7 years ago by Vickie Lynch (previous) (diff)

comment:2 Changed 7 years ago by Vickie Lynch

  • Owner set to Vickie Lynch

comment:3 Changed 7 years ago by Vickie Lynch

  • Milestone changed from Backlog to Release 3.0

comment:4 Changed 7 years ago by Vickie Lynch

Refs #7650 get coordinates from input MD workspaces

Changeset: a8a7dbd4487bd13b142aaf4c52525af554d1a138

comment:5 Changed 7 years ago by Vickie Lynch

Refs #7650 fix performance test; remove changes to scripts

Changeset: b4da7224c21cab0f2ab04fd23fa1a7a6690c21e0

comment:6 Changed 7 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test integrate without the CoordinatesToUse input parameter: 

Load(Filename='TOPAZ_6674_event.nxs',OutputWorkspace='TOPAZ_6674_event',FilterByTofMin='2000',FilterByTofMax='16500',LoadMonitors='1',MonitorsAsEvents='1')
ConvertToDiffractionMDWorkspace(InputWorkspace='TOPAZ_6674_event',OutputWorkspace='TOPAZ_6674_MD',OutputDimensions='Q (sample frame)',SplitThreshold='50',MaxRecursionDepth='11')
FindPeaksMD(InputWorkspace='TOPAZ_6674_MD',PeakDistanceThreshold='0.471',MaxPeaks='100',OutputWorkspace='peaks_ws')
CentroidPeaksMD(InputWorkspace='TOPAZ_6674_MD',PeaksWorkspace='peaks_ws',OutputWorkspace='peaks_ws')
FindUBUsingFFT(PeaksWorkspace='peaks_ws',MinD='4',MaxD='12',Tolerance='0.12')
IndexPeaks(PeaksWorkspace='peaks_ws',Tolerance='0.12')
SelectCellOfType(PeaksWorkspace='peaks_ws',CellType='Rhombohedral',Centering='R')
IntegratePeaksMD(InputWorkspace='TOPAZ_6674_MD',PeakRadius='0.1',PeaksWorkspace='peaks_ws',OutputWorkspace='peaks_ws_sphere')

comment:7 Changed 7 years ago by Keith Brown

  • Status changed from verify to verifying
  • Tester set to Keith Brown

comment:8 Changed 7 years ago by Keith Brown

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7650_coordinates_auto_from_MDworkspace'

Full changeset: ​90b0d2f0bc97827af891515efe156be7d9110beb

comment:9 Changed 7 years ago by Keith Brown

Satisfied that the algorithm will get the units from the new workspace, and still supports old scripts by showing a warning

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8495

Note: See TracTickets for help on using tickets.