Ticket #7661 (closed: fixed)
[IDA] Resolution parameter in IPF
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | spencer.howells@… | Blocked By: | |
| Blocking: | Tester: | Martyn Gigg |
Description
New ticket request from Spencer:
Following comment at the Mantid meeting we can have the default values for the integration related to the 'resolution' parameter I've put into the 'analyser' IPF files. In the gui code get 'parameter' from the parameter section (just like efixed) and set the range to +/- resolution.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
To Test
Elwin now uses the resolution set in the parameter file for an instrument if it exists. If not it will default to use the old setting of +/- 0.02.
Use and existing *_red.nxs file and open it in Eliwn and click plot input. The old default range of +/- 0.02 should be used.
Use the C2E interface to make and new *_red.nxs file. Then run this file through Elwin ensuring you plot the input. The result should be that it uses the resolution set in the parameter file rather than the old default as the range.
comment:3 Changed 7 years ago by Russell Taylor
- Status changed from verify to reopened
- Resolution fixed deleted
- Milestone changed from Backlog to Release 3.0
I'm pretty sure this has broken the following system tests:
SystemTests.ISISIndirectInelastic.IRISElwinAndMSDFit SystemTests.ISISIndirectInelastic.OSIRISElwinAndMSDFit
Please verify this and, if so, fix (you may just need to update the system test's reference results) or at least back this out of develop to get things passing again.
comment:4 Changed 7 years ago by Samuel Jackson
Problem was not with this ticket. System tests were broken by floating point differences when changing logarithm algorithm from python to c++ in ticket #7660.
comment:5 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to verify
- Resolution set to fixed
comment:6 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:7 Changed 7 years ago by Martyn Gigg
This has been on develop for some time and the tests are now okay.
I've checked the interface with a fresh reduction file and it does what is expected with the new resolution parameter.
Elwin now reads default resolution from parameter files.
Also updated parameter files accordingly.
Refs #7661
Changeset: b25c72b6e7ee9f2989eac5ec373bd8a484af544f