Ticket #7689 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

The IncreasingAxisValidatorTest should not use WorkspaceCreationHelper

Reported by: Russell Taylor Owned by: Arturs Bekasovs
Priority: critical Milestone: Release 3.0
Component: Framework Keywords:
Cc: martyn.gigg@… Blocked By:
Blocking: Tester: Russell Taylor

Description

TestHelpers::WorkspaceCreationHelper has a dependency on DataObjects so may not be used in an API test (see http://www.mantidproject.org/Mantid_Package_Diagram). You'll have to find another way to do it - have a look at TestHelpers::FakeObjects::WorkspaceTester, that might work for you.

Once that is done, the changes made to the API/test/CMakeLists.txt under #3005 that refer to DataObjects should be reverted.

Change History

comment:1 Changed 7 years ago by Arturs Bekasovs

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Arturs Bekasovs

Make the test use FakeObjects instead of WorkspaceCreationHelper.

Refs #7689

Changeset: ac65aae039ce5420ddc2c766ac091debf3512740

comment:3 Changed 7 years ago by Arturs Bekasovs

Revert changes done to CMakeLists.

Refs #7689

Changeset: 17dc4fc6202b0a2a908bbc7f490d323f036b97ee

comment:4 Changed 7 years ago by Arturs Bekasovs

Tester:

Just make sure that WorkspaceCreationHelper is not used in IncreasingAxisValidatorTest anymore, and that changes made to CMakeLists in d97cc5eb86c57a4147f23bab01b3343607633d13 are really reverted in 17dc4fc6202b0a2a908bbc7f490d323f036b97ee.

comment:5 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:7 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Good

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8534

Note: See TracTickets for help on using tickets.