Ticket #7704 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Make LeBailFit and LeBailFunction work with Chebyshev background

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description

It is found that LeBailFit and LeBailFunction does not work with Chebyshev background well. Investigate the reason and make it work.

Attachments

2011B_HR60b2.irf (841 bytes) - added by Wenduo Zhou 7 years ago.
LB4853b2.hkl (22.1 KB) - added by Wenduo Zhou 7 years ago.
PG3_11486-2.dat (300.7 KB) - added by Wenduo Zhou 7 years ago.
verify_7704.py (6.2 KB) - added by Wenduo Zhou 7 years ago.

Change History

comment:1 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to inprogress
  • type changed from enhancement to defect

comment:2 Changed 7 years ago by Wenduo Zhou

Make LeBailFit/LeBailFunction work with Chebyshev. Refs #7704.

Changeset: 036ad09a0d8883ca7171a612e07070dfb04db175

comment:3 Changed 7 years ago by Wenduo Zhou

Resolved conflict from merging master. Refs #7704.

Changeset: b064bf7c151d12ee2e8161e503390dc3876a9e31

comment:4 Changed 7 years ago by Wenduo Zhou

Fixed some error due to merging master. Refs #7704.

Changeset: 4407de02d8166827f210d27bc665443f1f6481bc

comment:5 Changed 7 years ago by Wenduo Zhou

Fixed the unit test due to previous change. Refs #7704.

Changeset: f52b744294f3dc07e14be5ac160aec2df7944177

comment:6 Changed 7 years ago by Wenduo Zhou

Fixed an issuer. Refs #7704.

The issue was caused by re-definition of background function's order 'n'. If there is no input vector of background parameters, the default is set to n=0, A0 = 0.

Changeset: 6215dae7c13c4f97ea3c2ea9524549cc6e764c12

comment:7 Changed 7 years ago by Wenduo Zhou

Cleaned the codes. Refs #7704.

Changeset: 8ec2093925ecd5ba4abb85486008293a67f1000a

comment:8 Changed 7 years ago by Wenduo Zhou

Cleaned the codes. Refs #7704.

Changeset: a6e41fb22e72b74bd25748f4f6f8d41b9a8156d9

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

comment:9 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

Instruction to verify

  1. Download all the attached files;
  2. Build Mantid before merging this ticket's branch to master.
  3. Run script verify_7704.py.
  4. In the output workspace PG3_11486_Guessed, plot spectrum "Data" (i.e., raw experimental data) and "InBkgd" (background calculated from input parameters). You can see the background is way off;
  5. Merge the branch to master and build Mantid.
  6. Re-run the script, and you can find that the background match the data.

comment:10 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:11 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7704_chebyshev_bkgd'

comment:12 Changed 7 years ago by Jay Rainey

Testing

  • Tested using the above script and relevant data files.
  • The background was no longer way off when the changes were applied.
  • LeBailFit and LeBailFunction now work with Chebyshev background.
  • Tested on Ubuntu 12.04

Code review

  • Well written code and comments.

comment:13 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8549

Note: See TracTickets for help on using tickets.