Ticket #7711 (closed: fixed)
[IDA] Elwin does strange things with temperature.
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | Blocked By: | #7735 | |
| Blocking: | Tester: | Gesner Passos |
Description
Elwin is producing strange output under some circumstances during the generation of the _elf files.
Sometimes, plotting the _elf file causes the x axis to not be set to the correct scale, causing nothing to appear in the plot. Also, the labels on the axis often not correct. It should read "Temperature" but is instead showing either "Quantity" or "Run number".
Doing a fresh generation of the files using C2E and then running them through Elwin produces regular output, but saving them and then reloading them appears to cause issues.
It looks like Elwin may be falling back on some default values under some circumstances.
Attachments
Change History
comment:3 Changed 7 years ago by Samuel Jackson
The issue with "Quantity" is a separate, wider issue to do with file saving/loading and will be dealt with in ticket #7735
comment:6 Changed 7 years ago by Samuel Jackson
Refs #7711 Added check for whether temp is decreasing.
Changeset: d1fcb4d339bdd4540e1f000710045a6d8bcc7d0d
comment:7 Changed 7 years ago by Samuel Jackson
Merge branch 'bugfix/7711_elwin_temperature_fix' into develop
Refs #7711
Conflicts:
Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py
Changeset: 315ac507ccdfaae2fb00eaef9e87f09c71641809
comment:8 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Component changed from Framework to Indirect Inelastic
- Resolution set to fixed
To Tester
The problem with the x axis not plotting has been resolved in this ticket. The issue was down to the temperature (plotted on the x) decreasing in some runs meaning that plot spectrum became confused when the stating value was greater than the end value.
Use the supplied files as input to Elwin and plot the generated *_elf workspace. The graph should plot with a reasonable scale and temperature should descend towards the right.
comment:9 Changed 7 years ago by Samuel Jackson
- Status changed from verify to reopened
- Resolution fixed deleted
comment:10 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #7711 Forgot to flip Y and E axes as well.
Changeset: 2bd12407dc727b0720f31039720aa325a1c3c2d1
comment:11 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Gesner Passos
- Status changed from verify to verifying
- Tester set to Gesner Passos
comment:13 Changed 7 years ago by Gesner Passos
- Status changed from verifying to reopened
- Resolution fixed deleted
Everything works fine, but we have agreed that the notation:
datTx = datTx[::-1]
could be replaced by:
datTx.reverse()
improving readability.
comment:14 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #7711 Add comment to obscure code.
Changeset: 7249c7371acae5921307b689c92fe3e845ed8e5a
comment:15 Changed 7 years ago by Samuel Jackson
Refs #7711 Merge Master into branch to resolve conflict.
Changeset: f16ed8d9506dfdd2941d0d36d47c8f1276ee33b5
comment:16 Changed 7 years ago by Samuel Jackson
As discussed these are numpy arrays which don't have the reverse method. Instead I've added a comment to make it clearer what is happening.
comment:17 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:19 Changed 7 years ago by Gesner Passos
It was my fault, there is not reverse for the numpy array data type, and the way to reverse is through that code. So, now, a comment was given to add understanding.
comment:20 Changed 7 years ago by Samuel Jackson
- Status changed from verifying to closed
Merge branch 'bugfix/7711_elwin_temperature_fix' into feature/7711_elwin_temp_fix_2
Full changeset: a00ff657240a02a71afa6e17114e5d639809bbd3
comment:21 Changed 7 years ago by Gesner Passos
Merge remote-tracking branch 'origin/feature/7711_elwin_temp_fix_2'
Full changeset: 8cf1052aafa6ce069203deafa48426937a92547d
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8556
