Ticket #7748 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix GSoapGenerated location for cppcheck exclude

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: minor Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

The location of the GSoapGenerated directory in the cppcheck exclude list has changed. Fix it.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Michael Reuter

Refs #7748. Fixing cppcheck exclude locations.

Changeset: 7c7c7b0c02654824c5bff698eef3c5d8c5a30073

comment:3 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch is here.

To test: Run make -jN cppcheck before and after the fix and make sure all gsoap references go away.

comment:4 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

gsoap-related warnings are gone. Back down from 1300 to 'only' 450 warnings.

comment:6 Changed 7 years ago by Martyn Gigg

Put tcmalloc first in Kernel linker list.

Ensures that the custom tcmalloc replacement takes over the work of malloc everywhere on the system.

Other required changes:

  • Remove the unnecessary linking of all dependencies to every library. It is sufficient to link the 'global' dependencies to Kernel as this is linked to everything.
  • The Python libraries must also force loading tcmalloc first as they preload other libraries to avoid other bugs.

Refs #7748

Changeset: ea95d533b848e5ce2499462be677c831043a87c0

comment:7 Changed 7 years ago by Martyn Gigg

My apologies. The previous commit should have gone to #7798

comment:8 Changed 7 years ago by Martyn Gigg

Put tcmalloc first in Kernel linker list.

Ensures that the custom tcmalloc replacement takes over the work of malloc everywhere on the system.

Other required changes:

  • Remove the unnecessary linking of all dependencies to every library. It is sufficient to link the 'global' dependencies to Kernel as this is linked to everything.
  • The Python libraries must also force loading tcmalloc first as they preload other libraries to avoid other bugs.

Refs #7748

Changeset: b04e1b6a5fcfec6d04bc97017f880a0ca6eafb6d

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8593

Note: See TracTickets for help on using tickets.