Ticket #7767 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

The plot produced by the Step Scan Interface needs to include errors

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: critical Milestone: Release 3.0
Component: Framework Keywords: LiveData
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

This is easy if just plotting Counts (just add a column to the table with sqrt(events) ), but will be a bit more work if any normalising is done.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #7767. Add errors to the table output of SumEventsByLogValue.

Changeset: 992b3045f2dcdd41c4f951c435d08451336d4149

comment:2 Changed 7 years ago by Russell Taylor

Re #7767. Tweak the performance test.

To see if it leads to 'steadier' performance.

Changeset: 83907d07a4b8dd594dea7c73491d627e3f7a0413

comment:3 Changed 7 years ago by Russell Taylor

Re #7767. Add boilerplate test initialisation code.

Nothing to do with this ticket, but realised I missed this when I added this performance test recently.

Changeset: d73e2be9175338ffa0d0c97e771bc11da77eb493

comment:4 Changed 7 years ago by Russell Taylor

Re #7767. Include errors in the generated plot.

Changeset: a1b25934fcd5a002b0db2a3510b7c957ccc422b3

comment:5 Changed 7 years ago by Russell Taylor

Re #7767. Change title of workspace corresponding to plot.

People are going to want to fit to this data, so it doesn't make sense to make it a hidden workspace. Also amended the name so it starts with the same string as the table workspace.

Changeset: b6b102cf1225f0c92610ef04a41e03a896c9449e

comment:6 Changed 7 years ago by Russell Taylor

Re #7767. Update the StepScan workflow algorithm test.

Changeset: 658b2485c82f7c70bf06ae5324711c2c00ba4a3a

comment:7 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester: Branch is feature/7767_stepscan_add_errors

Despite the description, this was also easy for the normalisation case as I'm using the binary operations, which just do it right. So all that was required was to add the new error column when calling ConvertTableToMatrixWorkspace the first time in the StepScan custom interface.

To test, start up the Step Scan Interface from the Interfaces menu. The reference data to load is HYSA_2934.nxs.h5 from the systemtests repository. Just hit start once the file is loaded and you will see (very small) errors on the plot. Try changing the normalisation and check the errors update correctly. Note that the errors in this case will be wrong if #7779 hasn't already been merged - this is particularly noticeable if normalising by time. You can bring up the table and confirm that the error column correctly holds sqrt(counts).

comment:8 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:9 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7767_stepscan_add_errors'

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8612

Note: See TracTickets for help on using tickets.