Ticket #7793 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Remove default parameter element of IDFs

Reported by: Mike Thomas Owned by: Mike Thomas
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

To meet the requirements of the IDF schema: the following <parameter> element contains attributes form the element <logfile>. The parameter element is not a valid element of defaults and is to be removed from the following files: EMU_Definition_32detectors.xml EMU_Definition_96detectors.xml GPD_Definition_2detectors.xml HIFI_Definition.xml MUSR_Definition.xml

Erroneous Code:

<defaults>

<length unit="meter"/> <angle unit="degree"/> <parameter eq="" type="double" extract-single-value-as="mean" /> <reference-frame>

<!-- The z-axis is set parallel to and in the direction of the beam. the

y-axis points up and the coordinate system is right handed. -->

<along-beam axis="z"/> <pointing-up axis="y"/> <handedness val="right"/>

</reference-frame>

</defaults>

Replacement Code:

<defaults>

<length unit="meter"/> <angle unit="degree"/>

<reference-frame>

<!-- The z-axis is set parallel to and in the direction of the beam. the

y-axis points up and the coordinate system is right handed. -->

<along-beam axis="z"/> <pointing-up axis="y"/> <handedness val="right"/>

</reference-frame>

</defaults>

Change History

comment:1 Changed 7 years ago by Mike Thomas

  • Status changed from new to inprogress

Commit IDFs default correct Refs #7793

Changeset: d3a7b60af15d4d3fb3b2f9e43c8e85f0c2fbfdbd

comment:2 Changed 7 years ago by Mike Thomas

  • Owner set to Anders Markvardsen

comment:3 Changed 7 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester: changed accordign to description

comment:4 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:5 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7793_remove_default_parameter_element'

comment:6 Changed 7 years ago by Nick Draper

  • Owner changed from Anders Markvardsen to Mike Thomas

After the summer contact Anders Markvardsen about these tickets

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8638

Note: See TracTickets for help on using tickets.