Ticket #7795 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Correct coordinate attribute error in multiple IDFs

Reported by: Mike Thomas Owned by: Mike Thomas
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The error uses the attribute 'axis' instead of 'value' for the element <handedness>. Some IDFs that are written by other software have had this error replicated. This is being dealt with separately, see: ​https://github.com/mantidproject/mantidgeometry/issues/12

Erroneous Code:

<reference-frame>

<along-beam axis="z"/> <pointing-up axis="y"/> <handedness axis="right"/>

</reference-frame>

Replacement Code:

<reference-frame>

<along-beam axis="z"/> <pointing-up axis="y"/> <handedness val="right"/>

</reference-frame>

Change History

comment:1 Changed 7 years ago by Mike Thomas

Files with error:

ARCS_Definition_19000000-20121010.xml

ARCS_Definition_20121010-20121011.xml

ARCS_Definition_20121011-.xml

BASIS_Definition.xml

BIOSANS_Definition_2012.xml

CNCS_Definition.xml

CNCS_Definition_20120215-20120313.xml

CNCS_Definition_20120314_20120816.xml

CNCS_Definition_35155-44929.xml

EQ-SANS_Definition.xml

HIRESSANS_Definition.xml

HYSPECA_Definition.xml

HYSPEC_Definition.xml

MANDI_Definition_2012.xml

MANDI_Definition_2013_03_15.xml

NOMAD_Definition.xml

NOMAD_Definition_19000000-20120630.xml

NOMAD_Definition_20120701-20120731.xml

POWGEN_Definition_2010.xml

POWGEN_Definition_2011-02-25.xml

POWGEN_Definition_2012-08-20.xml

POWGEN_Definition_2012-11-27.xml

POWGEN_Definition_2013-06-01.xml

POWGEN_Definition_2013-08-01.xml

REF_L_Definition.xml

REF_M_Definition.xml

SANS_Definition.xml

SEQUOIA_Definition.xml

SEQUOIA_Definition_upto_19889.xml

SNAP_Definition.xml

SXD_Definition.xml

TOPAZ_Definition_2010.xml

TOPAZ_Definition_2011-01-01.xml

TOPAZ_Definition_2011-10-03.xml

TOPAZ_Definition_2011-10-21.xml

TOPAZ_Definition_2012-05-25.xml

TOPAZ_Definition_2012-08-23.xml

VISION_Definition.xml

VULCAN_Definition.xml

comment:2 Changed 7 years ago by Mike Thomas

  • Status changed from new to inprogress

Commit IDFs_correct_handedness_attribute Refs #7795

Changeset: e790590e95b4c9894b0131b1c967752ee9f07dd0

comment:3 Changed 7 years ago by Mike Thomas

  • Owner set to Anders Markvardsen

comment:4 Changed 7 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester: check coordinate attribute changed

comment:5 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:6 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to reopened
  • Resolution fixed deleted

REF_L_Definition.xml_backup, IDFs_for_UNIT_TESTING/MINITOPAZ_Definition.xml, IDFs_for_UNIT_TESTING/DUM_Definition.xml, CNCS_Definition_20120817_20130814.xml have the same problem

comment:7 Changed 7 years ago by Mike Thomas

  • Status changed from reopened to verify
  • Owner changed from Anders Markvardsen to Mike Thomas
  • Resolution set to fixed

These files were fixed under ticket #7781

comment:8 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying

comment:9 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7795_correct_multiple_IDF_handedness_attribute'

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8640

Note: See TracTickets for help on using tickets.