Ticket #7797 (closed: fixed)
CompAssembly::getComponentByName doesn't properly recurse
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.0 |
Component: | Framework | Keywords: | PatchCandidate |
Cc: | Blocked By: | ||
Blocking: | Tester: | Gesner Passos |
Description
This is evident when trying to use CreateGroupingWorkspace by bank for the latest powgen instrument. Add unit tests that expose the defect, then modify the code to make them pass.
Change History
comment:2 Changed 7 years ago by Peter Peterson
- Status changed from new to inprogress
Re #7797. Adding first pass of broken unit test of getComponentByName
Changeset: 1e2f88a82f2a6c83fd8ba17723aed3a99f76e796
comment:3 Changed 7 years ago by Peter Peterson
Re #7797. Adding more tests of getComponentByName.
Changeset: a600d76a5619860d96c75bbf317c5471a3e58df8
comment:4 Changed 7 years ago by Peter Peterson
Re #7797. Fixing nlevels functionality of getComponentsByName
Changeset: 2af50845abcaf480318a637d56f239a7dd49335b
comment:5 Changed 7 years ago by Peter Peterson
Re #7797. Small performance tweak.
Changeset: 17ca431434127ea627c865f84dc6ff7c39906cf1
comment:6 Changed 7 years ago by Peter Peterson
Re #7797. Expose the recursion depth to the user.
Changeset: d59a6a7f0666f71a4efac2796736c51054785c59
comment:7 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is on bugfix/7797_getComponentByName.
To test:
- Look at the tests for getComponentByName(). There wasn't any before and this is a big step forward.
- What pointed out the error was running CreateGroupingWorkspace with the latest POWGEN geometry and grouping by bank. See that this gives more than the 8 groups that it used to.
comment:8 Changed 7 years ago by Gesner Passos
- Status changed from verify to verifying
- Tester set to Gesner Passos
comment:9 Changed 7 years ago by Gesner Passos
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/7797_getComponentByName'
comment:10 Changed 7 years ago by Gesner Passos
It first 'proves' to solve the issue, but covering the problem with the unit test. The unit test effectively address the issue. The solution is clear and nice. And the solution of the algorithm getComponentByName effectively allows the groups to be correctly dealt with in CreateGroupingWorkspace.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8642