CompAssembly::getComponentByName doesn't properly recurse

[Peter Peterson]

This is evident when trying to use CreateGroupingWorkspace by bank for the latest powgen instrument. Add unit tests that expose the defect, then modify the code to make them pass.

[Peter Peterson]

Re #7797. Adding first pass of broken unit test of getComponentByName

Changeset: 1e2f88a82f2a6c83fd8ba17723aed3a99f76e796

[Peter Peterson]

Re #7797. Adding more tests of getComponentByName.

Changeset: a600d76a5619860d96c75bbf317c5471a3e58df8

[Peter Peterson]

Re #7797. Fixing nlevels functionality of getComponentsByName

Changeset: 2af50845abcaf480318a637d56f239a7dd49335b

[Peter Peterson]

Re #7797. Small performance tweak.

Changeset: 17ca431434127ea627c865f84dc6ff7c39906cf1

[Peter Peterson]

Re #7797. Expose the recursion depth to the user.

Changeset: d59a6a7f0666f71a4efac2796736c51054785c59

[Peter Peterson]

This is on ​bugfix/7797_getComponentByName.

To test:

1. Look at the tests for getComponentByName(). There wasn't any before and this is a big step forward.
2. What pointed out the error was running CreateGroupingWorkspace with the latest POWGEN geometry and grouping by bank. See that this gives more than the 8 groups that it used to.

[Gesner Passos]

Merge remote-tracking branch 'origin/bugfix/7797_getComponentByName'

[Gesner Passos]

It first 'proves' to solve the issue, but covering the problem with the unit test. The unit test effectively address the issue. The solution is clear and nice. And the solution of the algorithm getComponentByName effectively allows the groups to be correctly dealt with in CreateGroupingWorkspace.

[Stuart Campbell]

This ticket has been transferred to github issue ​8642