Ticket #7826 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Unit tests for some workflowalgorithms

Reported by: Gesner Passos Owned by: Samuel Jackson
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Samuel Jackson) (diff)

The indirect analysis workflowalgorithms:

  • Quest.py
  • JumpFit.py
  • MuscatFunc.py
  • ResNorm.py
  • ForCE.py
  • Moments.py
  • ILLines.py
  • IDAtransmission.py
  • Symmetrise.py
  • QLines.py
  • MuscatData.py

do not have unit tests.

These algorithms are wrappers for IndirectBayes, whose functionality is covered in IndirectBayesTest in systemtest. So, it is sufficient to test that it correctly parses the inputs to send to IndirectBayes.

A mock strategy to substitute IndirectBayes in order to allow it to call a mock function that does nothing, but allow checking the input would be sufficient, and nice as well.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Description modified (diff)

comment:2 Changed 7 years ago by Samuel Jackson

  • Description modified (diff)

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:4 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to verify
  • Resolution set to fixed

I'm going to mark this ticket as finished. A lot of this can and has been handled in other tickets. Of the remaining items in the list:

  • MuscatData and MuscatFunc are currently not working. Spencer is still working on them and unit tests should be added as part of ticket #5412
  • Moments has been done as part of ticket #9342
  • Symmetrise should has been added + refactored as part of #7860. A unit test should be added as part of that ticket instead.

comment:5 Changed 6 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.3

comment:6 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:7 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8671

Note: See TracTickets for help on using tickets.