Ticket #9342 (closed: fixed)
Indirect Python Algorithm Testing
| Reported by: | Samuel Jackson | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Indirect Inelastic | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Peter Peterson |
Description
We have some python algorithms which are tested in the system tests. These should really be moved to be unit tests in test/python/plugins/algorithms. Namely:
- DOSTest.py
- IndirectTransmissionTest.py
- IndirectMoments (In ISISIndirectInelastic.py)
Change History
comment:2 Changed 6 years ago by Samuel Jackson
- Keywords Maintenance added
- Milestone changed from Backlog to Release 3.3
comment:3 Changed 6 years ago by Samuel Jackson
- Status changed from assigned to inprogress
Refs #9342 Add proper unit test for DensityOfStates
Changeset: 490533787a3febda862da86c8d53fcebb1ef4aab
comment:4 Changed 6 years ago by Samuel Jackson
Refs #9342 Add unit test for IndirectTransmission
Changeset: 381ecde7a289f26f218c50867472515c76c38a78
comment:5 Changed 6 years ago by Samuel Jackson
Refs #9342 Add unit test for SofQWMoments
Changeset: dd130911918355ae916cfa27b6445ef07a975f8c
comment:6 Changed 6 years ago by Samuel Jackson
Merge branch 'feature/9342_indirect_py_alg_testing' into develop
Refs #9342
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt
Changeset: cc28a76e1075b37d24157cef1e316420a9ca8cbd
comment:7 Changed 6 years ago by Samuel Jackson
Refs #9342 Use method supported by RHEL6.
Changeset: ac727ad8e3435603af4ea1c08aab9c0739c6815f
comment:8 Changed 6 years ago by Andrei Savici
DensityOfStates algorithm fails on Fedora 20. My guess is that there is no scipy installed. Since scipy is not a mantid requirement (maybe it should), you should test if you can import it before you register the algorithm
comment:9 Changed 6 years ago by Samuel Jackson
Refs #9342 Add check for scipy include.
Changeset: d85b77e906d263394b48d4d2f993a0d4172f9cd2
comment:10 Changed 6 years ago by Samuel Jackson
Refs #9342 Fix for broken RHEL6 build.
Changeset: 4115a27dcefd82622c04172fd97c37cf8fd8ec4c
comment:11 Changed 6 years ago by Samuel Jackson
Refs #9342 Missed import.
Changeset: 54069a2c07d2954304e496b2cd95a912434d8915
comment:12 Changed 6 years ago by Samuel Jackson
Refs #9342 Skip tests (again).
Changeset: 1f8722c47d69a5ea493234567ec6f1f862aabc47
comment:13 Changed 6 years ago by Samuel Jackson
Refs #9342 Better test skipping implementation.
Changeset: 870980a8ae9aed858d48479b4edb23e6e7f47c58
comment:14 Changed 6 years ago by Samuel Jackson
Refs #9342 Remove IndirectTranmission test from system tests
Changeset: 865b436aabc47f9ba190703c0c21911adb8cc1c8
comment:15 Changed 6 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
To Test
There's now unit tests for each one of these in the appropriate testing folder. I've left the system tests for Moments and DensityOfStates in as checking the reference results is still useful at the moment.
comment:16 Changed 6 years ago by Samuel Jackson
Merge branch 'feature/9342_indirect_py_alg_testing' into develop
Refs #9342
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt
Changeset: cc28a76e1075b37d24157cef1e316420a9ca8cbd
comment:18 Changed 6 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:19 Changed 6 years ago by Peter Peterson
- Status changed from verifying to reopened
- Resolution fixed deleted
You forgot to push the systemtests branch.
comment:20 Changed 6 years ago by Martyn Gigg
- Owner changed from Dan Nixon to Martyn Gigg
- Status changed from reopened to verify
- Resolution set to fixed
It looks like no one got to testing this before Sam left. I've logged on to his machine and found the branch and it is now on github.
comment:22 Changed 6 years ago by Pete Peterson
Merge remote-tracking branch 'origin/feature/9342_indirect_py_alg_testing'
Re #9342.
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt
Changeset: ab23408d3e940237612f0738a09e6ec4ad2d7a6c
comment:23 Changed 6 years ago by Pete Peterson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9342_indirect_py_alg_testing'
Re #9342.
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt
Full changeset: ab23408d3e940237612f0738a09e6ec4ad2d7a6c
comment:24 Changed 6 years ago by Pete Peterson
Merge remote-tracking branch 'origin/feature/9342_indirect_py_alg_testing'
Full changeset: b5c5c7228ebd63bbe8ee567322fa8e8e20492d90
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10185
