Ticket #9343 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Unit Tests for IndirectCommon

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Currently, the functions in IndirectCommon are only tested indirectly by the system tests. It would be better if we included some unit tests for these functions in scripts/test.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Samuel Jackson

  • Keywords Maintenance added
  • Milestone changed from Backlog to Release 3.3

comment:3 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9343 Add unit tests for indirect common script.

Changeset: 9b7d3686353fa35c50ae156d1c780ec9d86d3e03

comment:4 Changed 6 years ago by Samuel Jackson

Refs #9343 Do some re-factoring.

Changeset: 1bf6b211784221bdc27409c3bbb1f9da4edb5596

comment:5 Changed 6 years ago by Samuel Jackson

Refs #9343 Checkpointing work so far

Changeset: 1cf94ffb81bbf96e4816e40b8f24e0bacd6a7f0e

comment:6 Changed 6 years ago by Samuel Jackson

Refs #9343 Refactor function to use existing code

Changeset: 355a5d75f53dcb87482202fe6a9ab4d532643887

comment:7 Changed 6 years ago by Samuel Jackson

Refs #9343 Remove unused function.

Searched code base and it appears this is no longer needed anywhere.

Changeset: d9f09856f3795f4d67ac11747bb756b84f2dc42b

comment:8 Changed 6 years ago by Samuel Jackson

Refs #9343 Remove unused argument.

This option does nothing and is not used, so should be removed.

Changeset: ab2c43b7af387eec6681a5aa52058cc7fb4411f3

comment:9 Changed 6 years ago by Samuel Jackson

Refs #9343 Refactor extract functions.

Changeset: 062a7498413a4bc1803570c8e629267a5757f5bc

comment:10 Changed 6 years ago by Samuel Jackson

Refs #9343 Checkpointing work.

Changeset: e9d65a47b9621cda25e6843d002ca87bf1f14785

comment:11 Changed 6 years ago by Samuel Jackson

Refs #9343 Apply stashed changes.

Changeset: cb22c4750a8ce51f8ec6d893b91ee8cb54d538f4

comment:12 Changed 6 years ago by Samuel Jackson

Refs #9343 Adding more tests.

Changeset: bb20947d1986f1654cd3542d8d21cf946af6c8bf

comment:13 Changed 6 years ago by Samuel Jackson

Refs #9343 Updating documentation and removing debug statements.

Changeset: 47ba528a089ed53662570ea2dabff18b87be2f77

comment:14 Changed 6 years ago by Samuel Jackson

To Test

The new unit test suite should be passing on develop, so check it's passing an do a code review.

comment:15 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:16 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:17 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9343_indirect_common_script_tests'

Full changeset: 257d218bddc4287d5cc32dba251bf61815706993

comment:18 Changed 6 years ago by Owen Arnold

Fine, and a good idea, these tests are running on each incremental build and take upwards of 2 seconds to run. So it would be good to speed up these tests if possible.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10186

Note: See TracTickets for help on using tickets.