Ticket #7835 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IDA] Update ApplyCorrections to use ConvertSpectrumAxis

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Martyn Gigg

Description

Updates from Spencer. We can do some minor changes to ApplyCorrections so that it uses ConvertSpectrumAxis

Attachments

IndirectDataAnalysis.py​ (47.0 KB) - added by Samuel Jackson 7 years ago.
Spencer's updated file with mods on lines 1091-2, at 1053 & around 1031-32

Change History

Changed 7 years ago by Samuel Jackson

Spencer's updated file with mods on lines 1091-2, at 1053 & around 1031-32

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #7835 Update ApplyCorr to use ConvertSpectrumAxis.

Changeset: b6be77da90836db8a2d6fdcc716a4cc92f12670b

comment:2 Changed 7 years ago by Samuel Jackson

Refs #7835 Removed obselete code.

Changeset: c84130112f9261a0a45cbceef0c2e548c281b34e

comment:3 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Milestone changed from Backlog to Release 3.0

To Tester

Run through Apply Corrections on the IDA interface and check that the modifications have not affected the output. Instructions can be found here:

http://www.mantidproject.org/Indirect:Indirect_Data_Analysis#Running_Apply_Corrections

comment:4 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:7 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to verify
  • Tester Jay Rainey deleted

comment:8 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:9 Changed 7 years ago by Martyn Gigg

Code changes look good and the results still match the examples.

comment:10 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7835_update_ApplyCorr_to_use_ConvertSpecAxis'

Full changeset: ​64ce7bdd88e005955a4f90705be93ee391bd2be6

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8680

Note: See TracTickets for help on using tickets.