Ticket #7844 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Migrate RetrieveRunInfo

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: critical Milestone: Release 3.0
Component: Python Keywords:
Cc: Blocked By:
Blocking: #7690 Tester: Russell Taylor

Description

Get the commit from #7690 to make the ticket #7690 just a collection of blocking tickets.

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Blocking 7690 added

comment:2 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

comment:3 Changed 7 years ago by Gesner Passos

Migrate RetrieveRunInfo to new api

re #7844

Changeset: fbe09cf363b166b2ed3a19a73a4eee85966cecdc

Last edited 7 years ago by Gesner Passos (previous) (diff)

comment:4 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester:

The example should work. 

config['default.facility'] = 'ISIS'
config['default.instrument'] = 'LOQ'
if mtd.doesExist('ws'):
	DeleteWorkspace('ws')
ws = RetrieveRunInfo(Runs='48097-48098')

And code review to check that no old api is being used.

comment:5 Changed 7 years ago by Gesner Passos

  • Priority changed from major to critical

needs to be tested by 30/08 to allow removing old api.

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:7 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The test - already in Framework/PythonInterface/test/python/plugins/algorithms - needs attention. I think all it needs is the v1 API imports at the top removed. If I do that, the test passes for me - otherwise it fails.

comment:8 Changed 7 years ago by Gesner Passos

This file passed without being noticed in #7690. But, it depends on the old api.

I will check it.

comment:9 Changed 7 years ago by Gesner Passos

  • Status changed from reopened to inprogress

Migrate the RetrieveRunInfoTest to new api

re #7844

Changeset: 02025251d2169d7957b7d48c3624ac7c9d67a045

comment:10 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/7844_migrate_retrive'

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8689

Note: See TracTickets for help on using tickets.