Ticket #7845 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Modify BinCount in FindPeaks

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

For event md workspaces, use getNumPoints. For histogram md workspaces, use getSignalNormalized.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

Re #7845. Removing gcc compiler warning.

This has nothing to do with the ticket, but it is really annoying me.

Changeset: 8632b13642fa7481fac875381f346e84c4bc907e

comment:2 Changed 7 years ago by Peter Peterson

Re #7845. Adding branch to get number of events in the box.

Changeset: 39465b2dd27d06727af89edef62eb21f2314ca0e

comment:3 Changed 7 years ago by Peter Peterson

Re #7845. Fixing unit test.

Changeset: b6f505f2b0f84715783ff00dc66b836933c3adc7

comment:4 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on ​feature/7845_bincount.

To test:

  • use the "SCD event data reduction interface" through the FindPeaks
  • look at the peaks (in slice viewer will probably be best) and note that the BinCount is more reasonable for the number of events in the center box of the peak

comment:5 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:6 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Now, binCount shows more reasonable numbers.

comment:7 Changed 7 years ago by Russell Taylor

This looks to be the ticket that broke the Diffraction_Workflow & ReduceOneSCD system tests. Looks like we're set for a bunch of red jobs.

comment:8 Changed 7 years ago by Russell Taylor

The system tests were repaired in #7858.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8690

Note: See TracTickets for help on using tickets.