Ticket #7846 (closed: fixed)
Print out new lattice constants after TransformHKL
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.0 |
Component: | Diffraction | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Andrei Savici |
Description
Just so people have confirmation of what they transformed to. The format should be similar to FindUBUsingFFT.
Change History
comment:2 Changed 7 years ago by Peter Peterson
Re #7846. Using new ostream operator in UnitCell.
Refactored some bits of code to be using c++ formating rather than sprintf. Also moved things from the header to the implementation.
Changeset: 16eab47ad957fccfdbd60de9a0f0b17c0f739dd3
comment:3 Changed 7 years ago by Peter Peterson
Re #7846. Printing out transformed lattice constants.
Also moved some implementation from the header files.
Changeset: 368f9f8e09f1968d422fb75f4eab7065f1c10dc3
comment:4 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is on feature/7846_print_lattice.
To test: Run the "SCD Event Reduction" interface through the point of "Change HKL." You should see the lattice constants printed just before a copy sample in the Results Log.
comment:5 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:6 Changed 7 years ago by Russell Taylor
- Status changed from verifying to reopened
- Resolution fixed deleted
Turns out I haven't a clue how to drive the SCD interface. However, a couple of things from looking at the code:
- How about quickly writing a unit test for the new stream operator
- The test for showUncertainties around lines 709-721 of UnitCell.cpp is strange code - why not just use one 'if' and a bunch of 'or's?
comment:8 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
For some reason the last commit didn't get added to the ticket.
comment:9 Changed 7 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester changed from Russell Taylor to Andrei Savici
comment:10 Changed 7 years ago by Andrei Savici
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7846_print_lattice'
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8691
Re #7846. Adding operator<< to UnitCell.
This is being done to centralize the code for printing out lattice constants and their uncertainties.
Changeset: 3956568929d0696b13ad9ddecb9923f2be239169