Ticket #7855 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Move rest of REFL API v1 to API v2

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: blocker Milestone: Release 3.0
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: #7690 Tester: Michael Reuter

Description (last modified by Mathieu Doucet) (diff)

From comment:30 of #7690

Warnings to the following files:

They may generate old api scripts 

Mantid/scripts/Interface/reduction_gui/reduction/reflectometer/refl_sf_calculator.py
Mantid/scripts/Interface/reduction_gui/reduction/reflectometer/refl_reduction.py
Mantid/scripts/Interface/reduction_gui/widgets/reflectometer/base_ref_reduction.py
Mantid/scripts/Interface/reduction_gui/widgets/reflectometer/refl_sf_calculator.py

Using old api: 

Mantid/scripts/Interface/reduction_gui/widgets/reflectometer/refl_reduction.py
Mantid/scripts/Interface/reduction_gui/widgets/reflectometer/stitcher.py
Mantid/scripts/Interface/reduction_gui/widgets/reflectometer/launch_peak_back_selection_1d.py
Mantid/scripts/Interface/reduction_gui/widgets/reflectometer/refl_data_simple.py
Mantid/scripts/reduction/instruments/reflectometer/data_manipulation.py

Change History

comment:1 Changed 7 years ago by Mathieu Doucet

  • Description modified (diff)

comment:2 Changed 7 years ago by Mathieu Doucet

  • Status changed from new to inprogress

Re #7855 Remove old API from Refl code

Changeset: 65e7fb25a058b2bffc9c958b4aaedc18edb26853

comment:3 Changed 7 years ago by Mathieu Doucet

Re #7855 Remove commented code

Changeset: 9faff60a633ccfff341b69b1c2175b9741b758a5

comment:4 Changed 7 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

Jean should test drive the reduction to test this ticket

comment:5 Changed 7 years ago by Mathieu Doucet

  • Tester set to Jean Bilheux

comment:6 Changed 7 years ago by Gesner Passos

  • Blocking 7690 added

comment:7 Changed 7 years ago by Mathieu Doucet

  • Milestone changed from Backlog to Release 3.0

comment:8 Changed 7 years ago by Mathieu Doucet

  • Priority changed from critical to blocker

comment:9 Changed 7 years ago by Mathieu Doucet

Re #7855 Fix issue with int property

Changeset: f1a02ee0ecc11c00a38228c4b5f5854663925f51

comment:10 Changed 7 years ago by Mathieu Doucet

Re #7855 Fix issue with int property (fix conflict)

Changeset: 8942ac592a7ed75f91521adf46427ab2b7e571e7

comment:11 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester changed from Jean Bilheux to Michael Reuter

comment:12 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

There are conflicts against master that need fixing.

comment:13 Changed 7 years ago by Mathieu Doucet

  • Status changed from reopened to inprogress

Re #7855 Resolve conflict with master

Changeset: 4d4e45487ab90ef22036197c17bc2173547e2806

comment:14 Changed 7 years ago by Mathieu Doucet

Re #7855 Fix conflict with develop

Changeset: 6256d19aa16e2c07b9ad5af81654e1c048162b1a

comment:15 Changed 7 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

Should now work.

comment:16 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:17 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

More conflicts found.

comment:18 Changed 7 years ago by Mathieu Doucet

  • Status changed from reopened to inprogress

Re #7855 Fixing refl

Changeset: 1014f071183e310d6f5f2d899785aaa0acbf5942

comment:19 Changed 7 years ago by Mathieu Doucet

Re #7855 fix conflict with master

Changeset: a978899c24da26e49548cfb580d0f55718791bf4

comment:20 Changed 7 years ago by Mathieu Doucet

Re #7855 Fix minor conflict

Changeset: fbe681c185761730edc512da817e78ab8ab5d17f

comment:21 Changed 7 years ago by Mathieu Doucet

Re #7855 resolving minor conflict

Changeset: cf6faf3eee6c6c9f327bf5ee875dce47c6f74dbf

comment:22 Changed 7 years ago by Mathieu Doucet

Re #7855 Fix conflict with most recent version of master

Changeset: 3e85ead80dbdd23e174d08656d539419cef39915

comment:23 Changed 7 years ago by Mathieu Doucet

Re #7855 sync versions

Changeset: 4315137a524021c8a3924a7c51ebdddef3f2ab2a

comment:24 Changed 7 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

Everything should now work. If there's any API v1 remaining, please create another ticket so that we can avoid the merging issues we've had with this ticket.

comment:25 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:26 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7588_finish_removing_refl_old_api'

comment:27 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Reflectometry

comment:28 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8700

Note: See TracTickets for help on using tickets.