Ticket #7894 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Rename the image view

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.0
Component: GUI Keywords: SpectrumView
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

This should be called "Spectrum View" since that is what it actually visualizes.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Keywords SpectrumView added

comment:2 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

comment:3 Changed 7 years ago by Peter Peterson

Re #7894. Renamed ImageViewer subproject to SpectrumViewer.

Changeset: c9092848cd86d61ee66889709cac5257bf5cf679

comment:4 Changed 7 years ago by Peter Peterson

Re #7894. Changed the name of the include directory.

Changeset: 3c878711383682369164fc1415eb3c6a85fe9cd3

comment:5 Changed 7 years ago by Peter Peterson

Re #7894. Renaming image view in windoze installer.

Changeset: 6128e9a6e97cd7fe2577bb4db229c5ad4c756805

comment:6 Changed 7 years ago by Peter Peterson

Re #7894. Changed the namespace to SpectrumView

Changeset: 1d905381dcdfdee19fc7aede1c31a85c5cc6aea1

comment:7 Changed 7 years ago by Peter Peterson

Re #7894. Renamed ImageView class to SpectrumView.

Changeset: e82d22ed73b26155cf25e1dd2051cc711eb93751

comment:8 Changed 7 years ago by Peter Peterson

Re #7894. Changed reference in comments.

Changeset: 6be4b4794fcdbe410281f1e768c1432cd91b3aa3

comment:9 Changed 7 years ago by Peter Peterson

Re #7894. Getting rid of more ImageView references.

Changeset: 0dc2de6824d18b6ebd03a716b54e1afc8ccd72fe

comment:10 Changed 7 years ago by Peter Peterson

Re #7894. Renamed ImagePlotItem to SpectrumPlotItem.

Changeset: 971a9074a342d494c5bf903be48ed1b6beff2430

comment:11 Changed 7 years ago by Peter Peterson

Re #7894. Renamed ImageDisplay to SpectrumDisplay.

Changeset: 81d6844f57af2a44f062baa0134ebc7e3c1a423c

comment:12 Changed 7 years ago by Peter Peterson

Re #7894. Changed export name.

Changeset: 97c2efd258b39e21f102435fafddf067281db0fd

comment:13 Changed 7 years ago by Peter Peterson

Re #7894. Renamed ImageDataSource to SpectrumDataSource.

Changeset: 5957b03082dbbabcf68ccdb92b6dfaca36daaffe

comment:14 Changed 7 years ago by Peter Peterson

Re #7894. Renamed right-click menu item in workspace dock.

Changeset: ea8a0a447f60e349f04aef02d65a015af68e6857

comment:15 Changed 7 years ago by Peter Peterson

Re #7894. Renamed DllOptionIV.h to DllOptionSV.h.

Changeset: 57419f7b78956ac47259fe56c8e1d10b80fd12ec

comment:16 Changed 7 years ago by Peter Peterson

Re #7894. Renamed IVUtils to SVUtils.

Changeset: 061986556f0df57714e320a4f7bbbe208f909df9

comment:17 Changed 7 years ago by Peter Peterson

Re #7894. Renamed IVConnections to SVConnections.

Changeset: 1cfef85be3c1ac378d216ff1af0660c6c3dfb955

comment:18 Changed 7 years ago by Peter Peterson

Re #7894. Fixing define macro for windoze.

Changeset: e66b3e411e55eb38351a035419b39f1449513a7a

comment:19 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on feature/7894_rename_image_view.

To test you can either look at the changes in 67 files across 15 commits, or you can:

  • Load some event file
  • Right click on the workspace and "Show Spectrum Viewer"

Nothing at all has been changed other than the names so this will still have all of the blemishes as before.

comment:20 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:21 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I'm ignoring all things REF.

The slot call in MantidDock to MantidUI::showImageViewer didn't get changed. This also points out that MantidUI didn't get updated as well.

Class/file name fixes:

  • MatrixWSImageView should be MatrixWSSpectrumView
  • ImageViewDemo should be SpectrumViewDemo
  • ImageViewNxEventFile should be SpectrumViewNxEventFile

Here are some other things that didn't get fixed:

EModeHandler:
* EModeHandler( Ui_SpectrumViewer* iv_ui );
* Ui_SpectrumViewer* iv_ui;
MatrixWSImageView:
* SpectrumView *image_view;
* Wrong class on doxygen
RangeHandler:
* RangeHandler( Ui_SpectrumViewer* iv_ui );
* Ui_SpectrumViewer* iv_ui;
SVConnections:
* SVConnections( ..., SpectrumView* image_view, ...);
*  Ui_SpectrumViewer*  iv_ui;
*  SpectrumView*       iv_main_window;
SliderHandler:
* SliderHandler( Ui_SpectrumViewer* iv_ui );
* Ui_SpectrumViewer* iv_ui;
SpectrumDisplay:
* SpectrumDisplay(  QwtPlot*       image_plot, ...);
* SpectrumDisplay::UpdateImage() ???
* SpectrumPlotItem*       image_plot_item;
SpectrumView:
* SpectrumDisplay* spectrum_display = new SpectrumDisplay( ui->imagePlot, ...);
ImageViewNxEventFile:
* MantidQt::SpectrumView::MatrixWSImageView image_view( WS );

In SVConnections the link to the wiki documentation should be changed, but that means changing the page name and page content as well.

comment:22 Changed 7 years ago by Peter Peterson

  • Status changed from reopened to inprogress

Re #7894. Renamed MantidUI::showImageViewer to showSpectrumViewer.

Changeset: eb55584a1abd1fdac218206a6bc381f73748ac45

comment:23 Changed 7 years ago by Peter Peterson

Re #7894. More Image to Spectrum class renames.

Changeset: c4ad3ca3bb99e10c889567aded98b099f98c260a

comment:24 Changed 7 years ago by Peter Peterson

Re #7894. Bulk field renaming.

Changeset: de3e2a81df01eaab31cf75ebc6a45616d63af684

comment:25 Changed 7 years ago by Peter Peterson

Re #7894. Bulk field renaming.

Changeset: df2319aeecdb70a84fd4fb1f3136cb3116b820fe

comment:26 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:27 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:28 Changed 7 years ago by Michael Reuter

Renaming looks good. SpectrumViewer seems to work as before.

comment:29 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7894_rename_image_view'

comment:30 Changed 7 years ago by Michael Reuter

Oops. Missed the wiki documentation bit. Opened #7941 in response.

comment:31 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8739

Note: See TracTickets for help on using tickets.