Ticket #7983 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Algorithm to determine the Mean

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #7982 Tester: Wenduo Zhou

Description

We do not appear to have any algorithm that can determine the Mean of two workspaces.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Owen Arnold

  • Blocking 7982 added

(In #7982) It might be more sensible yet, to determine whether there are complete zeros in the errors for all spectra and apply either WeightedMean, or Mean based on the outcome. We have no Mean algorithm, so I'm going to do that under a separate ticket (#7983).

comment:3 Changed 7 years ago by Owen Arnold

refs #7983. Create a binary operation algorithm for the Mean.

Implementation and unit tests.

Changeset: 434acadaa20aa67eca844f1fe15583beb3556152

comment:4 Changed 7 years ago by Owen Arnold

refs #7983. Fix compiler warnings.

Changeset: 50c5827d5c87fb0f4af3acbb0cc3bb6e2482ee25

comment:5 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Milestone changed from Backlog to Release 3.0

comment:6 Changed 7 years ago by Owen Arnold

Tester: It should be quite simple to demonstrate how this should be working. Use unit tests as a guide.

comment:7 Changed 7 years ago by Owen Arnold

  • Tester set to Gesner Passos

comment:8 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying

comment:9 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I discussed with Owen to extend the definition of this algorithm to allow n workspaces.

comment:10 Changed 7 years ago by Owen Arnold

What I'm going to do is to ditch this branch + code changes, and start afresh by implementing a very simple python algorithm to do the job. We can add performance later if required. Will now implement and algorithm called Mean, which takes a StringList property of workspace names.

comment:11 Changed 7 years ago by Owen Arnold

  • Status changed from reopened to inprogress

refs #7983. Implement python algorithm.

Python algorithm and tests created.

Changeset: 697692ac73e782b4052971fb0e659b1b29a01016

comment:12 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:13 Changed 7 years ago by Owen Arnold

Tester. This algorithm should produce the same results as (ws1 + ws2)/2. It just makes that functionality slightly more accessible for users who are happy using the GUI, but not necessarily python.

comment:14 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester changed from Gesner Passos to Wenduo Zhou

comment:15 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

It works for the purpose.

comment:16 Changed 7 years ago by Owen Arnold

refs #7983. Implement python algorithm.

Python algorithm and tests created.

Changeset: cad9fa381ca4fab9ce0060569463ed7f97a9ab57

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8828

Note: See TracTickets for help on using tickets.