LoadEventNexus does not load sample information for ISIS data

[Gesner Passos]

Execute the code below, and you will see that the sample information is different between ws and ws_ev.

ws = LoadNexus(Filename=r'LET00006278.nxs')
ws_ev = LoadEventNexus(Filename=r'LET00006278.nxs')
print ws.sample().getGeometryFlag() 
print ws_ev.sample().getGeometryFlag()

It has an effect in the SANS reduction for ISIS.

[Gesner Passos]

Load Sample information in Event Data for ISIS

It creates a new method to load the sample information from the data file. It does essentially the same job of LoadISISNexus2::loadSampleData, but, due to different libraries being used, I was forced to 'duplicate' the code.

re #7985

Changeset: b3e7e78ac783efdde8ec0cbbe69eec85a5ba8f03

[Gesner Passos]

CoverageTest for Loading ISIS Event data

There is not ISIS Event data in the Mantid repository. So, this SystemTest was added to cover specific parts of the algorithm LoadEventNexus that apply to ISIS data.

re #7985

Changeset: 89d5de3b737da329e4d0f22ad09a204738dec1ef

[Gesner Passos]

Tester:

Execute the script in the description and check that the output is the same.

[Michael Reuter]

ISIS RHEL6 develop tests are saying this is broken. However, all other sets seem to indicate things are fine. Please investigate.

[Gesner Passos]

It seems that the rhel6 was not getting the correct version of the development to test the system test against. Without changing anything, just asking to test again correctly, everything passed.

[Michael Reuter]

This is fine, but I think a real unit test is necessary at some point in the near future. See #8016.

[Michael Reuter]

Merge remote-tracking branch 'origin/feature/7985_loadisisevent_coverage'

[Michael Reuter]

Merge remote-tracking branch 'origin/bugfix/7985_load_event_sample_detail'

[Stuart Campbell]

This ticket has been transferred to github issue ​8830