Ticket #7987 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Apply absorption correction to unfocussed vanadium

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: critical Milestone: Release 3.2
Component: Diffraction Keywords:
Cc: Blocked By: #7953, #8074
Blocking: Tester: Wenduo Zhou

Description

This is to take advantage of the work done to make MultipleScatteringCylinderAbsorption event aware (#7953).

Change History

comment:1 Changed 7 years ago by Peter Peterson

Ashfia has just agreed to get rid of the noise run.

comment:2 Changed 7 years ago by Peter Peterson

  • Blocked By 8074 added

comment:3 Changed 7 years ago by Peter Peterson

  • Milestone changed from Release 3.0 to Release 3.1

comment:4 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.1 to Backlog

Moved to backlog at the end of Release 3.1

comment:5 Changed 7 years ago by Peter Peterson

  • Priority changed from major to critical
  • Status changed from new to inprogress
  • Milestone changed from Backlog to Release 3.1

Ashfia is pressing hard for this one to be "done" before the cycle starts.

comment:6 Changed 7 years ago by Peter Peterson

Re #7987. Simplified the filterwall usage for characterizations.

Changeset: cec3f5ae84da4a632724aa8368efd15f40592530

comment:7 Changed 7 years ago by Peter Peterson

Re #7987. Removing cut-and-paste code.

Changeset: e9e6dd0bf2701b14c2bb7f74a3de29c27a9a2f66

comment:8 Changed 7 years ago by Peter Peterson

Re #7987. Small changes to reduction script.

Changeset: 01f624648d47c14c4800a95f2cf4393c0bb6a8e1

comment:9 Changed 7 years ago by Peter Peterson

Re #7987. Removed noise run option from SNSPowderReduction.

Changeset: 0d0614f1e5d56700c834d7c079e60ec07edc7327

comment:10 Changed 7 years ago by Peter Peterson

Re #7987. Simpler check for eventworkspace.

Changeset: 80c00ecb48c0854e332c1ed4a9b30e6402ac336c

comment:11 Changed 7 years ago by Peter Peterson

Re #7987. All data is normalized by pcharge now.

Changeset: a9ce6ce7b2d914bcc62c7d5717ab3a3b7e881ab0

comment:12 Changed 7 years ago by Peter Peterson

Re #7987. Making the chunking workspace far more temporary.

Changeset: 8aea996d90f6d583605b35176748789de1e038fa

comment:13 Changed 7 years ago by Peter Peterson

Re #7987. Removing the last little bits of the vanadium noise run.

Changeset: 2c6ffa8dd390bc492d05e3e3a5d217bb807a068b

comment:14 Changed 7 years ago by Peter Peterson

Re #7987. Moved vanadium correction to be before focusing the data.

This does break all of the chunking work for vanadium and its background. Hopefully we can get this back soon.

Changeset: 9485aec13a4b1d86da1b0fd4b70df5115a7c27e2

comment:15 Changed 7 years ago by Peter Peterson

Re #7987. Always load the vanadium background, use it, and delete it.

Changeset: 1073812078a3868ad635300f6fefebbf0e6d2f76

comment:16 Changed 7 years ago by Peter Peterson

Re #7987. Removing assign for parameter that went away.

Changeset: 39f714b78e96fed72164bc7fcf95cef76c82a58f

comment:17 Changed 7 years ago by Peter Peterson

Re #7987. Update reference results. These could be wrong.

Changeset: cfcbbc8f3ea5fdb4ca1573839245616aa77eae82

comment:18 Changed 7 years ago by Peter Peterson

Re #7987. Removing assign for parameter that went away.

Changeset: 84c97e023d30cb3f2386bfde6162c7c42ed2dd45

comment:19 Changed 7 years ago by Peter Peterson

Re #7987. Update reference results. These could be wrong.

Changeset: 24575ac8159a1b60734cc26fcc3fec00c1d87176

comment:20 Changed 7 years ago by Peter Peterson

  • Milestone changed from Release 3.1 to Release 3.2

comment:21 Changed 7 years ago by Peter Peterson

Re #7987. Adding now needed include for debug printing.

Changeset: 182e25210898a4fb03a35fe236eab72fe89753b4

comment:22 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Tester set to Wenduo Zhou

This is on feature/7987_powder_refactor and systemtests/feature/7987_powder_refactor. Both need to be merged.

To test: Run SNSPowderReduction on PG3_15053 with vanadium background 15085. Before the change, this will show a big ugly bump in high-d (between 10-12 Angstroms). After the change it is gone. Ashfia said that it is good enough for the changes to get merged, so the next round of work can start.

comment:23 Changed 7 years ago by Peter Peterson

Re #7987. Adding now needed include for debug printing.

Changeset: a294247274dbc441b777d2bafe32372961f111f0

comment:24 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying

comment:25 Changed 7 years ago by Peter Peterson

Merge remote branch 'origin/master' into feature/7987_powder_refactor

Conflicts:

SystemTests/AnalysisTests/ReferenceResults/PG3_4844_reference.gsa

Re #7987

Changeset: a6756fe376ac6a459de2db32064d9b175fa63510

comment:26 Changed 7 years ago by Peter Peterson

Re #7987. Updating reference results.

Changeset: bfd2534b7ff253ad32477eda49e770cb931b6aca

comment:27 Changed 7 years ago by Peter Peterson

Merge branch 'feature/7987_powder_refactor' into develop

Conflicts:

SystemTests/AnalysisTests/ReferenceResults/PG3_4844_reference.gsa

Re #7987

Changeset: 21a77b4033c0d2ddb99c31bd5f6e3320987b82d5

comment:28 Changed 7 years ago by Peter Peterson

This needed master merged in to both systemtests and mantid for things to work. It *should* be working.

comment:29 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7987_powder_refactor'

Full changeset: 2071864ef78842bce676b4e18ef95ace9785090f

comment:30 Changed 7 years ago by Wenduo Zhou

Merge remote-tracking branch 'origin/feature/7987_powder_refactor'

Full changeset: f37962fbbeaa55f5e293a456c7392686dc2aac9f

comment:31 Changed 7 years ago by Wenduo Zhou

The problem reported is solved by this ticket. So the ticket can be closed.

comment:32 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8832

Note: See TracTickets for help on using tickets.