Make calibration file optional in AlignAndFocusPowder

[Peter Peterson]

Allow for the case of only some of the calibration information being specified. This will have the following features:

• If CalFileName is empty, then skip it
• If there is no offsets, use ConvertUnits rather than AlignDetectors
• If there is no grouping, don't run DiffractionFocussing

[Peter Peterson]

Re #8074. Making CalFile optional.

Checks for whether it is empty and not grabbing workspaces. Filled in the check for grouping workspace before diffraction focussing. Also did a bit better checking on CropWorkspaces.

Changeset: 098c601c558bfaf30eb0f268cf58fd1236ab86a1

[Peter Peterson]

Re #8074. Made MaskDetectors and AlignDetectors optional.

Changeset: 05a5e64f499247916f7d25ffb774ed91549a333e

[Peter Peterson]

Re #8074. Moving code from header to source.

Changeset: cc3b8843295fafbc6171817c4f0fe48552bce65c

[Peter Peterson]

Re #8074. Only pass the reqiored arguments to EditInstrGeom.

Changeset: b9b0b830ab450d9243097f5ee7b818e229a8aecf

[Peter Peterson]

Re #8074. Refactored SetInstrumentGeometry and added a CompressEvents.

Changeset: 19721e14ea52bf0c5fa52f5e19590c6c27332f10

[Peter Peterson]

Re #8074. Added progress bar AlignAndFocusPowder

Changeset: 581050a8bb4c0961c6d304244b6997a15df8f416

[Peter Peterson]

This is on ​feature/8074_alignandfocus.

To test:

• Load an event file
• Load a cal file
• Try different variants of specifying the calibration file (and not) for the various special workspaces

Some parameters to start with:

• Nexus file: NOM_14526_event.nxs
• CalFileName=/SNS/NOM/IPTS-8607/shared/NOM_calibrate_d14526_2013_05_18.cal
• ResampleX=-3000
• Dspacing=True
• DMin=.13
• DMax=31.42
• TMin=300
• TMax=16666.67
• PreserveEvents=True
• RemovePromptPulseWidth=50
• L2=2,2,2,2,2,2
• Polar=15,31,67,122,154,7

[Gesner Passos]

I'm afraid I do not have the data files to test this ticket. BTW, I could not find unittest or system test for AlignAndFocusPowder to give me a hint on how to test it.

[Peter Peterson]

#8084 is to make a unit test.

[Wenduo Zhou]

The algorithm can execute without neither cal file nor mask/group/offset workspaces. It works for the purpose.

But when there isn't cal file to load or group workspace given, editing instrument geometry should be disabled automatically regardless of the input to geometry related properties such as L2 and 2-theta.

[Peter Peterson]

Re #8074. Don't edit instrument without grouping.

Changeset: 3459ea94f491fd971522e5debe34e723a5cf9759

[Wenduo Zhou]

The modification eliminates the bug reported. Thus ticket is closed.

[Wenduo Zhou]

Merge remote-tracking branch 'origin/feature/8074_alignandfocus'

Full changeset: ​7ce73e57b243c078e00492c6ef6cddd51480d9c2

[Stuart Campbell]

This ticket has been transferred to github issue ​8919