Ticket #8000 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

InstrumentTest.py does nothing

Reported by: Gesner Passos Owned by: Martyn Gigg
Priority: critical Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

The unit test for the export of the instrument, does nothing. 

Code/Mantid/Framework/PythonInterface/test/python/mantid/geometry/InstrumentTest.py

The class InstrumentTest must inherit from unittest.TestCase.

If you do so, you will see that this 'unit test' is broken.

If possible, add also a security check for getBaseInstrument. Changes made in #7607 broke that exported method and we were no aware of.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Martyn Gigg

Resurrect test for Python instrument export.

It had been implemented incorrectly and it looked as if it was passing when it wasn't. There was also a bug with the getReferenceFrame import that this also caught and fixed. Refs #8000

Changeset: 8a1706bf72d81a536a6a644d7afaf43fb1e49475

comment:3 Changed 7 years ago by Martyn Gigg

Solve compiler warnings about const casting noted by gcc 4.7.2

Note technically related to this ticket but while we're improving tests... Refs #8000

Changeset: 5d0f37b2b9ba3db28bc173d9df4c10ba69366495

comment:4 Changed 7 years ago by Martyn Gigg

Change argument from by-value to to reference to const.

Avoids an unnecessary incref/decref of the internal PyObject pointer when it is copied and destroyed. Refs #8000

Changeset: f88b85099f8c5b722855d615855c86d8a182470e

comment:5 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: bugfix/8000_python_instrumenttest

Tester: You should run ctest -R PythonInterfaceGeometry_InstrumentTest -V and check that it says "Ran 8 tests" in the output.

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:7 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/8000_python_instrumenttest'

comment:8 Changed 7 years ago by Russell Taylor

The actual objective of this ticket checked out OK. It's also nice to see that most of the warnings on newer GCCs are gone.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8845

Note: See TracTickets for help on using tickets.