[ConvFit] Error with fitting parameter

[Samuel Jackson]

This error was flagged up by Franz when trying to run a ConvFit.

ValueError: Invalid value for property Function (Function) "name=LinearBackground,A0=0.0227540307358,A1=0,ties=(A1=0.0);(composite=Convolution;name=Resolution, FileName="C:/Users/Adya/osi102558_graphite002_res.nxs";(name=DeltaFunction,Amplitude=1.81880428125;name=Lorentzian,Amplitude=5.33184635503,PeakCentre=-0.000381442045517,HWHM=0.0753037360806))": ParamFunction (set) parameter (Amplitude) does not exist.
Allowed parameters: Height,
at line 14 in '<Interface>'
caused by line 204 in 'C:/MantidInstall/scripts/Inelastic\IndirectDataAnalysis.py'
caused by line 115 in 'C:/MantidInstall/scripts/Inelastic\IndirectDataAnalysis.py'
caused by line 185 in 'C:/MantidInstall/bin\mantid\simpleapi.py'

Looks like it doesn't like the fitting parameter "Amplitude"

[Samuel Jackson]

Found I could reproduce the error by running the following python code and swapping the DeltaFunction parameter "Amplitude" to "Height" allows the code to run fine

filename = "/home/chs18285/Downloads/irs55127_graphite002_red.nxs"
func = "name=LinearBackground,A0=0.0227540307358,A1=0,ties=(A1=0.0);(composite=Convolution;name=Resolution, FileName="+filename+";(name=DeltaFunction,Amplitude=1.81880428125;name=Lorentzian,Amplitude=5.33184635503,PeakCentre=-0.000381442045517,HWHM=0.0753037360806))"
Fit(Function=func,InputWorkspace="irs55127_graphite002_red",WorkspaceIndex=0,Output="out",MaxIterations=0)

[Samuel Jackson]

Refs #8015 Swapped "Amplitude" parameter for "Height"

Changeset: 6fc0c6e8377e10a19462a636a2edc8a7af173d3c

[Samuel Jackson]

To Tester

This error can be reproduced by running a sequential ConvFit and checking use delta function.

Instructions for running it can be found here: http://www.mantidproject.org/Indirect:Indirect_Data_Analysis#Running_ConvFit

Verify you can reproduce the error, then try out the fixed version and check that it works.

[Jay Rainey]

Merge remote-tracking branch 'origin/feature/8015_convfit_parameter_error'

[Stuart Campbell]

This ticket has been transferred to github issue ​8860