Ticket #8054 (closed: fixed)
SANS remove spec_min and spec_max for options
| Reported by: | Gesner Passos | Owned by: | Gesner Passos |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | SANS | Keywords: | |
| Cc: | Blocked By: | #8055 | |
| Blocking: | #8052 | Tester: | Martyn Gigg |
Description
We keep spec_min and spec_max for loading SANS data in order to pass on as SpectrumMin and SpectrumMax eventhough they are not used, or just passed as None values.
There is only one single case where they can be used, is to load SANS2D files collected in 2009 (before run 568).
Now, that they are moving towards EventData, which does not provide this option, I suggest removing these attributes.
Change History
comment:3 Changed 7 years ago by Gesner Passos
- Status changed from new to inprogress
Remove not needed options for sans reduction
Remove spec_min and spec_max attributes to Tide up the code.
re #8054
Changeset: 718c11d2a056e159961c0eb596ac51af050b081c
comment:4 Changed 7 years ago by Gesner Passos
Tester:
The same test for #8055 should be sufficient.
comment:7 Changed 7 years ago by Gesner Passos
Remove not needed options for sans reduction
Remove spec_min and spec_max attributes to Tide up the code.
re #8054
Changeset: 4278948c57affd8d52c15accc9ee4ed2f614f773
comment:8 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
I'm publishing now, because #8055 has been merged to master. But it was already in the develop branch since 01/10/2013. It has already passed the system test.
comment:9 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:10 Changed 7 years ago by Martyn Gigg
Reduction completes as expected. Good to see my "temporary" code from 2 years being removed!
comment:11 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8054_remove_old_attributes'
Full changeset: a348ed2d08e4ca798dc916cfe8d9ca6afee99bbb
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8899
