Ticket #8055 (closed: fixed)
Use FileFinder for SANS reduction
| Reported by: | Gesner Passos | Owned by: | Gesner Passos |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | SANS | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #8054 | Tester: | Martyn Gigg |
Description
The LoadRun tries to do the job it should give to FileFinder.
Change History
comment:2 Changed 7 years ago by Gesner Passos
- Status changed from new to inprogress
Code improvement for SANS reduction
Rebuild _extract_run_details to use FileFinder instead of trying to find the file itself.
re #8055
Changeset: b6f55891f4abb73d495c4e6167668a7243fd8a20
comment:3 Changed 7 years ago by Gesner Passos
LOQ and SANS2D commands change the default instrument
re #8055
Changeset: b57108f2373564f4bc57b041457265bb27991bd9
comment:4 Changed 7 years ago by Gesner Passos
Tester:
passing the systemtest is enough, because, the code changed is executed in all the tests related to reducing sans2d and loq data.
comment:5 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
Tester:
if you want to test also the GUI operating a reduction, you may:
- Open SANS INTERFACE (Menu->Interfaces->SANS ISIS)
- Change the instrument to SANS2D
- Load the MaskFile: MASKSANS2D.091A (systemtests/Data/SANS2D)
- Change to BatchMode
- Load the SANS2D_nexusinputs.csv file http://trac.mantidproject.org/mantid/attachment/ticket/6740/SANS2D_nexusinputs.csv
- Execute: Reduce1D
It should reduce your data normally.
comment:6 Changed 7 years ago by Gesner Passos
Code improvement for SANS reduction
Rebuild _extract_run_details to use FileFinder instead of trying to find the file itself.
re #8055
Changeset: 186f802723faf55c6b8fd9a4605a2ded3be0770c
comment:7 Changed 7 years ago by Gesner Passos
LOQ and SANS2D commands change the default instrument
re #8055
Changeset: dfaa6abf10c0ad44527e9273be6e16317e876408
comment:8 Changed 7 years ago by Gesner Passos
Code improvement for SANS reduction
Rebuild _extract_run_details to use FileFinder instead of trying to find the file itself.
re #8055
Changeset: 2eaac8008cc91c39f62d0dade41ff7ce7589db2f
comment:9 Changed 7 years ago by Gesner Passos
LOQ and SANS2D commands change the default instrument
re #8055
Changeset: fc537c6b48aa6d4a2d2db1d4845058cb77b6cbd8
comment:10 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:11 Changed 7 years ago by Martyn Gigg
Good to see that the code is being simplified by re-using existing functionality.
comment:12 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8055_sans_file_finder' Full changeset: 2213fb1fb773b59f2716657aae481adb3b234ce0
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8900
