Ticket #8066 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add option to Fit to output convolved components

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

When fitting with Convolution and the model is a composite function Fit must have an option to output each model's component convolved with the resolution.

Attachments

test.nxs (64.7 KB) - added by Roman Tolchenov 7 years ago.

Change History

comment:1 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Added Fit option to output convolved composite components. Re #8066

Changeset: 62202ab61d3e79eabd4b8d22105db5989a5f4f01

comment:2 Changed 7 years ago by Roman Tolchenov

To tester:

  1. Create this function in Fit browser:

(composite=Convolution;name=Gaussian,Height=0.3989,PeakCentre=0,Sigma=1;(name=Gaussian,Height=1,PeakCentre=0,Sigma=1;name=Gaussian,Height=1,PeakCentre=1,Sigma=1)).

You can copy it to the clipboard then go to Setup->"Manage Setup"->"Load from string" in Fit browser and paste it there.

  1. Use the attached workspace to evaluate the function (Fit->"Evaluate function") with "Convolve members" option on and off.
  2. When the option is off the output workspace must contain 6 spectra: Data, Calc, Diff, Gaussian, Gaussian, Gaussian.
  3. When the option is off the output workspace must contain 5 spectra: Data, Calc, Diff, Convolution, Convolution.
  4. Compare the two last Gaussians from the "off" computation with the Convolutions from the "on" one. The Convolutions must be wider and lower.
Last edited 7 years ago by Roman Tolchenov (previous) (diff)

Changed 7 years ago by Roman Tolchenov

comment:3 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:4 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:5 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to inprogress

Updated the wiki description. Re #8066

Changeset: 344970d61453c8e18731951d0c7aed06e89abe36

comment:6 Changed 7 years ago by Roman Tolchenov

The option can apply now to not root level convolutions. Re #8066

Changeset: 3caff1f7549a6e8a37c133b2b27fd35c1a9b43f6

comment:7 Changed 7 years ago by Roman Tolchenov

Apply the option to a non-composite function in Convolution. Re #8066

Changeset: ef3424c6ae8502407a20e502285976ee8c530d5c

comment:8 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:9 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:10 Changed 7 years ago by Wenduo Zhou

It works well as described.

comment:11 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8066_output_convolved_components'

Full changeset: 15969870e88191edd6b7774e0f61b8b48d183066

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8911

Note: See TracTickets for help on using tickets.